Added four new CMake options #933
Conversation
SFML_BUILD_WINDOW, SFML_BUILD_NETWORK, SFML_BUILD_GRAPHICS, SFML_BUILD_AUDIO These all default to TRUE. When set to FALSE, the specified module will not be built. This can be useful if you are, for example, using only the Window module, and don't wish to install the dependencies of Graphics or Audio, just to build SFML.
|
#800 ... |
|
Why is nobody reading the contribution guidelines? 😞 Please don't just open a pull request when you feel like it, but discuss the issue first on the forum and check if nobody has suggested it yet. This simplifies things for everybody, as we don't have to discuss the same thing in different places, multiple times. It is okay to have multiple pull requests for one issue, but you have to refer to an existing one and argue what is fundamentally different in your implementation. Ideally, you first participate in the existing discussion and give feedback there. Do you basically agree with #800 (and for minor differences, give feedback)? If so, we can close this one. |
|
Yes, sorry. I briefly spoke to Tank about it on IRC, but he didn't remember the other one at the time, so I made this one. I'll close this one, since the other one already has had some discussion. Sorry! |
|
Sorry from my side as well. One thing, though: jagoly created the patch for himself mainly, and sent it in because others might benefit from it as well (classic FOSS principle). This is not a feature request that requires a preceeding discussion, it's more like a gift that we can take or not. The contribution guidelines help to not waste time building something and getting frustrated when we reject a PR. In this case I'm not so concerned about it, and the only good intervention I can see is by telling about the guidelines section which tells you to look for similar PRs first. ;) Anyway, thanks for the contribution jagoly, and sorry again. :) |
SFML_BUILD_WINDOW, SFML_BUILD_NETWORK, SFML_BUILD_GRAPHICS, SFML_BUILD_AUDIO
These all default to TRUE. When set to FALSE, the specified module will not be built. This can be useful if you are, for example, using only the Window module, and don't wish to install the dependencies of Graphics or Audio, just to build SFML.