-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the SOVERSION to major.minor. #812
Conversation
👍 |
This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
Since on Linux the shared libraries use |
I would agree with that change to the dll naming convention. |
Not sure about that. Doing that is very, very uncommon. Especially considering that Windows will always try to load dependencies straight from the executable's own folder anyway (so "bring your own stuff" is a lot easier to do). Also don't forget STL incompatibilities between toolchains and their versions. Just because you've got the same version DLL doesn't mean it's really compatible. |
Well... this is already the situation. You can't do much at all to fix this. Unless we started appending the compiler and it's version in the name also (never ever seen this done). |
Correct. So I'd just stick with the current approach and leave the Windows file names as-is. |
Any more comments on this (-2.2.dll vs -2.dll)? |
DLL hell is bad enough. I guess if we can prevent the dynamic linker from loading an incompatible (or simply the wrong) library, it wouldn't harm. -2.2.dll reveals the ABI version the best without having to resort to more elaborate methods. |
I say that DLLs should have the major and minor, but also think we should save that discussion for another time if it stalls this PR. After all, we do gain a few advantages with that change and don't really loose much at all. |
Given the other open issues, we're not in a hurry with the change. So I'm still interested in further comments. |
5dc183e
to
887cde1
Compare
Added the change for the DLLs, but I'm still open to comments about. |
This is about all I can think of regarding the change to dll naming. Pros
Cons
|
6944b86
to
2a2dca6
Compare
This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
2a2dca6
to
bbfa3d5
Compare
With this PR, we'll only change the soversion. The DLL stuff will be discussed elsewhere. |
Here are is the change as discussed.