Android: Accept touch events from "multiple" devices #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this would fail on `jpeg` and would detect something such as `notajpg` as `jpg`. This fixes #929.
At the moment, glCheck(...) and alCheck(...) look like a function calls, which is misleading and can cause subtle bugs, for example when used in if statements. This change mitigates the situation by allowing those expressions to be used as single statements within if/else branches. Initializations of OpenGL handles that previously involved glCheck() calls now need to be split into separate declaration and assignment.
Changes: * In addition to source file and line, the expression itself is output * For better readability, the log is split across multiple lines * alCheck() doesn't unnecessarily construct std::string when there is no error * Unused #include directives are removed
|
The Android people don't get anything pre-built. Including any Android specific fixes into any milestone makes no sense because they always build from master anyway. If they don't want to do so although we clearly label the mobile ports as still being experimental then they probably misunderstood the term "experimental". |
|
Right, forgot about that. :D |
|
Looks like either GitHub or Jenkins messed up, but it doesn't matter anyways. 😄 This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
Attempt to fix issue #953, although I can't really say whether this is indeed some driver thing. All snippets I've found use exact comparison only (usually switches).
eXpl0it3r
force-pushed
the
bugfix/xperia-touch
branch
from
fe58971
to
4f3c266
Compare
|
Merged in 4f3c266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #953, although I can't really say whether this is indeed some driver thing. All snippets I've found use exact comparison only (usually switches).
Considering this fix is pretty minor, only affects Android, and won't have any effects on other devices, I think we should even try to include it in 2.3.2/#952, what do you think?