-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Accept touch events from "multiple" devices #954
Conversation
Previously this would fail on `jpeg` and would detect something such as `notajpg` as `jpg`. This fixes #929.
At the moment, glCheck(...) and alCheck(...) look like a function calls, which is misleading and can cause subtle bugs, for example when used in if statements. This change mitigates the situation by allowing those expressions to be used as single statements within if/else branches. Initializations of OpenGL handles that previously involved glCheck() calls now need to be split into separate declaration and assignment.
Changes: * In addition to source file and line, the expression itself is output * For better readability, the log is split across multiple lines * alCheck() doesn't unnecessarily construct std::string when there is no error * Unused #include directives are removed
The Android people don't get anything pre-built. Including any Android specific fixes into any milestone makes no sense because they always build from master anyway. If they don't want to do so although we clearly label the mobile ports as still being experimental then they probably misunderstood the term "experimental". |
Right, forgot about that. :D |
Looks like either GitHub or Jenkins messed up, but it doesn't matter anyways. 😄 This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns. |
Attempt to fix issue #953, although I can't really say whether this is indeed some driver thing. All snippets I've found use exact comparison only (usually switches).
fe58971
to
4f3c266
Compare
Merged in 4f3c266 |
Fix for issue #953, although I can't really say whether this is indeed some driver thing. All snippets I've found use exact comparison only (usually switches).
Considering this fix is pretty minor, only affects Android, and won't have any effects on other devices, I think we should even try to include it in 2.3.2/#952, what do you think?