New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Accept touch events from "multiple" devices #954

Closed
wants to merge 17 commits into
base: 2.3.x
from

Conversation

@MarioLiebisch
Member

MarioLiebisch commented Aug 26, 2015

Fix for issue #953, although I can't really say whether this is indeed some driver thing. All snippets I've found use exact comparison only (usually switches).

Considering this fix is pretty minor, only affects Android, and won't have any effects on other devices, I think we should even try to include it in 2.3.2/#952, what do you think?

@mantognini

This comment has been minimized.

Show comment
Hide comment
@mantognini

mantognini Jul 4, 2015

Member

👍

Member

mantognini commented on 26fc872 Jul 4, 2015

👍

mickelson and others added some commits Jun 13, 2015

Fixed image file extension detection
Previously this would fail on `jpeg` and would detect something such as
`notajpg` as `jpg`. This fixes #929.
Made implementation of glCheck and alCheck macros more robust
At the moment, glCheck(...) and alCheck(...) look like a function calls, which is misleading and can cause subtle bugs, for example when used in if statements. This change mitigates the situation by allowing those expressions to be used as single statements within if/else branches.

Initializations of OpenGL handles that previously involved glCheck() calls now need to be split into separate declaration and assignment.
Improved diagnostic output for glCheck and alCheck macros
Changes:
* In addition to source file and line, the expression itself is output
* For better readability, the log is split across multiple lines
* alCheck() doesn't unnecessarily construct std::string when there is no error
* Unused #include directives are removed
@binary1248

This comment has been minimized.

Show comment
Hide comment
@binary1248

binary1248 Aug 27, 2015

Member

The Android people don't get anything pre-built. Including any Android specific fixes into any milestone makes no sense because they always build from master anyway. If they don't want to do so although we clearly label the mobile ports as still being experimental then they probably misunderstood the term "experimental".

Member

binary1248 commented Aug 27, 2015

The Android people don't get anything pre-built. Including any Android specific fixes into any milestone makes no sense because they always build from master anyway. If they don't want to do so although we clearly label the mobile ports as still being experimental then they probably misunderstood the term "experimental".

@MarioLiebisch

This comment has been minimized.

Show comment
Hide comment
@MarioLiebisch

MarioLiebisch Aug 27, 2015

Member

Right, forgot about that. :D

Member

MarioLiebisch commented Aug 27, 2015

Right, forgot about that. :D

@MarioLiebisch MarioLiebisch modified the milestones: 2.4, 2.3.2 Aug 27, 2015

eXpl0it3r and others added some commits Sep 10, 2015

@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 16, 2015

Member

Looks like either GitHub or Jenkins messed up, but it doesn't matter anyways. 😄

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Member

eXpl0it3r commented Sep 16, 2015

Looks like either GitHub or Jenkins messed up, but it doesn't matter anyways. 😄

This PR has been added to my merge list, meaning it will be merged soon, unless someone raises any concerns.

Android: Accept touch events from "multiple" devices
Attempt to fix issue #953, although I can't really say whether this is
indeed some driver thing. All snippets I've found use exact comparison
only (usually switches).
@eXpl0it3r

This comment has been minimized.

Show comment
Hide comment
@eXpl0it3r

eXpl0it3r Sep 18, 2015

Member

Merged in 4f3c266

Member

eXpl0it3r commented Sep 18, 2015

Merged in 4f3c266

@eXpl0it3r eXpl0it3r closed this Sep 18, 2015

@eXpl0it3r eXpl0it3r deleted the bugfix/xperia-touch branch Sep 18, 2015

@gjorando

This comment has been minimized.

Show comment
Hide comment
@gjorando

gjorando May 7, 2016

I think I got the fix for my issue (Arch Linux reporting my app isn't responding), thank you!

gjorando commented on 94dd1d7 May 7, 2016

I think I got the fix for my issue (Arch Linux reporting my app isn't responding), thank you!

@eXpl0it3r eXpl0it3r added this to Done in Android Backlog Jan 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment