renderer: Make sure that alpha is 1 for blend results.

SFTtech · Dec 15, 2023 · 8f1662e · 8f1662e
1 parent 5ae0c63
commit 8f1662e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/libopenage/renderer/opengl/renderer.cpp b/libopenage/renderer/opengl/renderer.cpp
@@ -27,8 +27,17 @@ GlRenderer::GlRenderer(const std::shared_ptr<GlContext> &ctx,
 	display{std::make_shared<GlRenderTarget>(ctx,
                                              viewport_size[0],
                                              viewport_size[1])} {
+	// color used to clear the color buffers
+	glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
+
 	// global GL alpha blending settings
-	glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
+	// glBlendFunc(GL_SRC_ALPHA, GL_ONE_MINUS_SRC_ALPHA);
+	glBlendFuncSeparate(
+		GL_SRC_ALPHA, // source (overlaying) RGB factor
+		GL_ONE_MINUS_SRC_ALPHA, // destination (underlying) RGB factor
+		GL_ONE, // source (overlaying) alpha factor
+		GL_ONE_MINUS_SRC_ALPHA // destination (underlying) alpha factor
+	);
 
 	// global GL depth testing settings
 	glDepthFunc(GL_LEQUAL);
@@ -157,7 +166,6 @@ void GlRenderer::render(const std::shared_ptr<RenderPass> &pass) {
 	auto gl_target = std::dynamic_pointer_cast<GlRenderTarget>(pass->get_target());
 	gl_target->bind_write();
 
-	glClearColor(0.0f, 0.0f, 0.0f, 0.0f);
 	glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
 
 	// TODO: Option for face culling

diff --git a/libopenage/renderer/stages/hud/render_stage.cpp b/libopenage/renderer/stages/hud/render_stage.cpp
@@ -69,7 +69,7 @@ void HudRenderStage::update() {
 			auto geometry = this->renderer->add_mesh_geometry(resources::MeshData::make_quad());
 			auto transform_unifs = this->drag_select_shader->new_uniform_input(
 				"in_col",
-				Eigen::Vector4f{0.0f, 0.0f, 0.0f, 0.5f});
+				Eigen::Vector4f{0.0f, 0.0f, 0.0f, 0.2f});
 
 			Renderable display_obj{
 				transform_unifs,