Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a parser for the new sprite format #1055

Closed
Vtec234 opened this issue Oct 6, 2018 · 8 comments · Fixed by #1497
Closed

Implement a parser for the new sprite format #1055

Vtec234 opened this issue Oct 6, 2018 · 8 comments · Fixed by #1497
Labels
area: assets Involved with assets (images, sounds, ...) area: renderer Concerns our graphics renderer just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code

Comments

@Vtec234
Copy link
Contributor

Vtec234 commented Oct 6, 2018

Contributing to the new renderer:

The renderer interface is defined in headers, with the main class in libopenage/renderer/renderer.h.
A good place to start looking is libopenage/renderer/tests.cpp, which presents a sample usage of the renderer. To run the test, after compiling Openage do ./run test -vd renderer.tests.renderer_demo 0.

Required knowledge:

  • Reading a file and parsing a regular language
  • You need to be familiar with how animations can be drawn from texture atlases.

What to modify:

  1. The new sprite format is defined in this doc. A parser for it should be implemented in libopenage/renderer/resources, using the existing Texture2d.. classes to store the actual data. The sprite could be stored in a class such as Sprite2dAnimated.
  2. A test for drawing animations with these sprites should be added to libopenage/renderer/tests.cpp, e.g. as test number 1. The animation timing logic should not be added to the renderer itself, but rather implemented on top of it.
  3. Documentation should be added to every new header and existing documentation updated to reflect changes.
@heinezen heinezen added area: renderer Concerns our graphics renderer hacktoberfest For newcomers from Hacktoberfest event labels Oct 6, 2018
@Montx
Copy link

Montx commented Oct 7, 2018

I would like to do this contribution.

@Vtec234
Copy link
Contributor Author

Vtec234 commented Oct 7, 2018

@Montx feel free to ask on IRC/Matrix about anything you might need.

@TheJJ
Copy link
Member

TheJJ commented Oct 7, 2018

Please include the documentation draft in the pull request so it becomes official (as doc/media/sprites.md).

@Montx
Copy link

Montx commented Oct 9, 2018

Sorry guys I thought I could pick this one up but I am on a mac and I can't update it to Mojave yet. So there are some functions on the game that are not supported by High Sierra. Currently I don't have my windows setup, and I can't mess with this mac, since it's not mine :/ Really frustrated with this, I could not find any work around. I hope I can still do some contributions in the future. Will continue to try and get a workaround.

@TheJJ TheJJ added just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code labels Nov 5, 2018
@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 30, 2018
@Firearrow5235
Copy link

I think I can handle this one. I've implemented SpriteSheet parsing and animation in MonoGame before. Just need to smash through those Windows build errors. 😝

@TheJJ TheJJ added the area: assets Involved with assets (images, sounds, ...) label Feb 1, 2019
@heinezen heinezen pinned this issue Feb 26, 2019
@TheJJ TheJJ unpinned this issue Feb 28, 2019
@heinezen heinezen pinned this issue Jul 1, 2019
@simonsan
Copy link
Contributor

@Firearrow5235 I attached a yaml-File for appveyor that should help you setting up your own pipeline. You still need to change the file extension and change some stuff inside. But openage should be building fine with this on windows. So you don't need to smash through those build errors. ;-)

appveyor_vcpkg.yml.txt

@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Oct 2, 2019
@aakashsoni-cloud
Copy link

aakashsoni-cloud commented Oct 22, 2019

How can I contribute to this project? please let me know.

@simonsan
Copy link
Contributor

@Aakash10-Coder You could read a bit through our contribution guide. Also I would recommend to pass by in the developers chat to figure out with the other people what can be done. :-)

@heinezen heinezen removed the hacktoberfest For newcomers from Hacktoberfest event label Nov 25, 2019
@SFTtech SFTtech deleted a comment Dec 2, 2019
@heinezen heinezen unpinned this issue Dec 28, 2022
@heinezen heinezen linked a pull request Mar 8, 2023 that will close this issue
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: assets Involved with assets (images, sounds, ...) area: renderer Concerns our graphics renderer just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code
Projects
None yet
7 participants