Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser for the new sprite format #1388

Closed
wants to merge 27 commits into from
Closed

Parser for the new sprite format #1388

wants to merge 27 commits into from

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented May 24, 2021 •
edited
Loading

Resolves #1055

  • Introduce new .texture format for texture and subtexture definition
    • specification
    • converter export
  • Parsers for definition files
    • sprite
    • texture
  • Storage classes for animation data
  • Renderer test
    • parsing
    • displaying loaded texture

@heinezen heinezen added area: assets Involved with assets (images, sounds, ...) lang: c++ Done in C++ code documentation Involves the project documentation lang: python Done in Python code area: renderer Concerns our graphics renderer labels May 24, 2021
@heinezen heinezen added this to todo in renderer via automation May 24, 2021
@heinezen heinezen added this to In progress in documentation via automation May 24, 2021
@heinezen heinezen added this to output in convert May 24, 2021
@heinezen heinezen moved this from In progress to Under Review in documentation May 24, 2021
@heinezen heinezen moved this from todo to in progress in renderer May 24, 2021
@heinezen
Copy link
Member Author

render-test

@heinezen heinezen changed the title [WIP] Parser for the new sprite format Parser for the new sprite format May 31, 2021
@heinezen heinezen force-pushed the render-parser branch 2 times, most recently from 40b8f6a to 8e6a722 Compare June 2, 2021 04:29
CyberHead
CyberHead previously approved these changes Jun 11, 2021
View reviewed changes
duanqn
duanqn previously approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@duanqn duanqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

openage/convert/value_object/read/media/smx.pyx Outdated Show resolved Hide resolved
openage/convert/value_object/read/media/slp.pyx Outdated Show resolved Hide resolved
openage/convert/value_object/read/media/slp.pyx Outdated Show resolved Hide resolved
openage/convert/value_object/read/media/slp.pyx Outdated Show resolved Hide resolved
libopenage/renderer/resources/texture_info.h Show resolved Hide resolved
libopenage/renderer/resources/texture_data.h Outdated Show resolved Hide resolved
@heinezen heinezen dismissed stale reviews from duanqn and CyberHead via 902e1b2 August 22, 2021 10:41
@heinezen
render: Test texture parsing.
f6f5cd8
@heinezen
render: Fix sprite parser.
38c36eb
@heinezen
render: Test sprite parsing.
02259c2
@heinezen
convert: Use relative module imports.
571f5e8
@heinezen
render: Test drawing texture from parsed animation file.
a438b51
@heinezen
export: Change the way the command bit is handled.
f578826 
Previously: Last Bit of alpha = 1 --> value is a command.
Now: Last Bit of alpha = 0 --> value is a command.

This makes rendering normal colors much easier, since their alphas can now be copied without a need for modification in the shader. alpha = 0 becomes a possible command as well.
@heinezen
render: Change filter for mangnifying to GL_NEAREST.
a9a24f3
@heinezen
render: Improve animation parser demo.
5052faa 
- Render subtexture with custom shader
- Add simple color command handling in fragmen shader
- Option to cycle through subtextures with left/right arrow keys
@heinezen
parser: Speedup parsing with constexpr maps for keywords and basic er…
d5b7924 
…ror handling.
@heinezen
render: Scale subtexture relative to texture size instead of window s…
4e970b5 
…ize.
@heinezen
render: Remove CSV metafile loading.
857ca8e
@heinezen
render: Better pth for input files.
5cf4f00
@heinezen
test: Add files for renderer test 1.
db30f3c
@heinezen
doc: Add parser namespace to docs.
0fda9b1
@heinezen
fix copyright years
700038d
@heinezen
parser: Throw error if file cannot be found.
880f5e3
@heinezen
doc: Wording in comments.
97c60b1
TheJJ
TheJJ requested changes Dec 29, 2022
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooh

doc/media/openage/texture_format_spec.md Show resolved Hide resolved
doc/media/openage/texture_format_spec.md Show resolved Hide resolved
doc/media/openage/texture_format_spec.md Show resolved Hide resolved
libopenage/datastructure/constexpr_map.h Show resolved Hide resolved
libopenage/renderer/opengl/texture.cpp Show resolved Hide resolved
openage/convert/value_object/read/media/smp.pyx Show resolved Hide resolved
openage/convert/value_object/read/media/smx.pyx Show resolved Hide resolved
openage/convert/value_object/read/media/slp.pyx Show resolved Hide resolved
openage/convert/value_object/read/media/slp.pyx Show resolved Hide resolved
openage/convert/value_object/read/media/slp.pyx Show resolved Hide resolved
@heinezen heinezen mentioned this pull request Feb 18, 2023
Merged
29 tasks
@TheJJ
Copy link
Member

TheJJ commented Apr 3, 2023

merged as part of #1497

@TheJJ TheJJ closed this Apr 3, 2023
convert automation moved this from output to done Apr 3, 2023
renderer automation moved this from in progress to done Apr 3, 2023
documentation automation moved this from Under Review to Done Apr 3, 2023
@heinezen heinezen deleted the render-parser branch October 15, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ requested changes

@duanqn duanqn duanqn left review comments

@CyberHead CyberHead CyberHead left review comments

Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) area: renderer Concerns our graphics renderer documentation Involves the project documentation lang: c++ Done in C++ code lang: python Done in Python code
Projects
documentation
  
Done
convert
  
done
renderer
  
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a parser for the new sprite format
4 participants
@heinezen @TheJJ @duanqn @CyberHead