Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CMake version to 3.16, buildsystem update to Python search #1264

Merged
merged 1 commit into from
May 19, 2020

Conversation

simonsan
Copy link
Contributor

@simonsan simonsan commented May 7, 2020

buildsystem: Integrate with new Python3.cmake functions (NumPy)

fixes #1246
ref.: #1263

@simonsan simonsan added improvement Enhancement of an existing component area: buildsystem Related to our cmake/python buildsystem labels May 7, 2020
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx.
can you also quickly fix the typo here please? it should say to add_pxds instead of to add_pyd.

CMakeLists.txt Show resolved Hide resolved
buildsystem/HandlePythonOptions.cmake Outdated Show resolved Hide resolved
@simonsan simonsan force-pushed the buildsystem/Bump-CMake-Version branch from b7b6514 to 76b4e52 Compare May 7, 2020 13:03
@simonsan simonsan requested a review from TheJJ May 7, 2020 13:04
TheJJ
TheJJ previously approved these changes May 8, 2020
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@TheJJ
Copy link
Member

TheJJ commented May 8, 2020

now, this depends on the kevin container update, which will happen soon™.

@simonsan
Copy link
Contributor Author

Waiting for #1268

@TheJJ
Copy link
Member

TheJJ commented May 19, 2020

Can you rebase pls?

@TheJJ TheJJ merged commit d890a60 into SFTtech:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: buildsystem Related to our cmake/python buildsystem improvement Enhancement of an existing component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document optional possibility to hardcode a Python directory
2 participants