add debug overlay grid, togglable with F4 #138
Conversation
|
|
||
| coord::camgame t = coord::tile{0, 0}.to_tile3().to_phys3().to_camgame(); | ||
|
|
||
| int dx = ((t.x + 96) % 96); |
There was a problem hiding this comment.
use cpp/util/misc.h:mod() functions to avoid negative number fuckups.
|
v2, please review :D |
|
should this be on the engine instead of game_main.cpp? |
|
the |
| @@ -589,6 +594,8 @@ bool GameMain::on_draw() { | |||
| // draw terrain | |||
| terrain->draw(&engine); | |||
|
|
|||
| if (this->debug_grid_active) { this->draw_debug_grid(); } | |||
There was a problem hiding this comment.
I think somewhere in our style guide it says to always put code blocks in the next line, even if it's just one statement, i.e.
if (condition) {
statement()
}
There was a problem hiding this comment.
seems reasonable!
There was a problem hiding this comment.
|
Apart from that missing newline it all looks good now; squash and it's ready to merge. (C programmers are notorious for using extremely short identifiers because back in the days when it was invented, before video terminals existed, the code was in fact printed by the 300-baud ASR33 teltypes those UNIX gods were using for coding. I don't even have a printer :P) |
|
lol hahahaha squashed and rebased |
| coord::camgame camera = coord::tile{0, 0}.to_tile3().to_phys3().to_camgame(); | ||
|
|
||
| int cam_offset_x = util::mod(camera.x, 96); | ||
| int cam_offset_y = util::mod(camera.y, 48); |
|
fixed a magic number, now it's fine |
|
(closes #135 on merge?) |
|
|
||
| glBegin(GL_LINES); | ||
| glVertex3f(i * e.tile_halfsize.x * 2 + cam_offset_x - line_half_width + e.tile_halfsize.y * 2, cam_offset_y - line_half_height - 1, 0); | ||
| glVertex3f(i * e.tile_halfsize.x * 2 + cam_offset_x + line_half_width + e.tile_halfsize.y * 2, cam_offset_y + line_half_height - 1, 0); |
There was a problem hiding this comment.
although the compiler will most likely optimize it, you could extract the redundant multiplications to a common variable.
There was a problem hiding this comment.
that common variable would be Engine::tile_size. Seriously, tile_halfsize? What retard had that idea? looks at git blame uhm nvm
TheJJ
added
lang: c++
|
done! ready for more fixes :D |
| glVertex3f(i * tilesize_x + x1, y1 - 1, 0); | ||
| } | ||
|
|
||
| glEnd(); |
There was a problem hiding this comment.
one finaly style thing: this is the preferred style for glBegin blocks (should add that somewhere to the codestyle doc).
There was a problem hiding this comment.
You don't sound all too convinced :)
Had you not used two indentations for some reason, I wouldn't even have noticed.
|
👍 |
|
👍 merged the change is, my padawan |
game: add debug overlay grid, togglable with F4
|
awwwwwwwww yissssssss |
game: add debug overlay grid, togglable with F4
Inspired on #135.
This simply draws 2d lines over the screen: it has no fancy shaders or anything. It won't work once we have terrain altitude. But it has helped me to spot what I think it's a bug on the coordinate conversion code :D also, it's useful for fixing #57.