Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New input management #1501

Closed
wants to merge 50 commits into from
Closed

New input management #1501

wants to merge 50 commits into from

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Mar 16, 2023 •
edited
Loading

New input handling and connection to engine

  • Low level inputs
    • QEvent to InputEvent
    • context management
    • forwarding to controllers and GUI
  • High level inputs
    • camera controller
    • engine controller
  • Game Entity creation

For later?

  • Prioritized event processing (e.g. try GUI first, then send event elsewhere if it's not accepted by the GUI)
  • Use callbacks instead of forwarding to controller
  • configuration format for keybindings
  • simulation/engine structure refactoring

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code big stuff High-impact changes, mainly foundation work labels Mar 16, 2023
@heinezen

This comment was marked as outdated.

Sign in to view
@heinezen heinezen force-pushed the input-controller branch 2 times, most recently from bd49449 to 2432dee Compare April 1, 2023 17:50
@heinezen heinezen marked this pull request as ready for review April 2, 2023 06:41
@heinezen
input: Use legacy namespace for old classes.
dc2ebd5
@heinezen
input: Refactor usable methods from legacy classes.
6fb704b
@heinezen
input: New input manager flow.
ae3cbe4
@heinezen
input: Separate key events, bindings and contexts more.
8a03097
@heinezen
input: Rearrange event lookup functions.
2b236b6
@heinezen
input: Simplify event class and store QEvent.
fb31dfc
@heinezen
input: Reintroduce bindings for event classes.
f2c5ea1
@heinezen
input: Logging output for events.
68c7ca5
@heinezen
presenter: Forward inputs to input manager.
b68af88
@heinezen
input: Pass mouse positions alongside key events.
93190e5
@heinezen
input: Get active bindings from input manager.
a4dedf8
@heinezen
input: Allow testing class relationships.
eb8b63a
@heinezen
input: Fix event and context operations.
308c1b6
@heinezen
input: Basic demo for context switching.
d033862
@heinezen
input: Allow flags in event arguments.
7c9e1a6
@heinezen
input: Fix confusion between pop and remove action.
d078182
@heinezen
input: Prevent unnecessary context pushs.
b9bbaa2
@heinezen
input: Comments for test.
ce9fc83
@heinezen
input: Add missing docstrings.
1a670a0
@heinezen
renderer: Capture all key/mouse input event types from Qt.
13e8b55
@heinezen
input: Store basic class/key combinatio in ClassCode.
3a48410
@heinezen
doc: Input management documentation.
3515760
@heinezen
input: Default bindings for camera movements.
d5a8676
@heinezen
input: Default (camera) bindings for input manager.
086c1e1
@heinezen
input: Check if binding exists in controller.
2f53cc3
@heinezen
input: Get event from text.
117088f
@heinezen
gamestate: Entity factory.
aa72087
@heinezen
gamestate: Use simulation in engine.
1f8af79
@heinezen
gamestate: Spawn entities with event handler.
ebad9ea
@heinezen
input: Spawn gaben on mouse click.
df2f9ab
@heinezen
engine: Store entity spawner in engine for now.
bdacfb1 
Should be moved somewhere where it makes more sense.
@heinezen
event: Fix missing lock in event loop.
0e8d127
@heinezen
event: Save gamestate in simulation.
ed98169
@heinezen
gamestate: Threaded access to entity factory.
c4a5937
@heinezen
input: Remove unnecessary static casts.
029ec0a
@heinezen
main: pass gamestate to simulation.
518485e
@heinezen
event: Recursive mutex for event loop.
985daf9 
Fixes a deadlock for callbaks from invokes.
@heinezen heinezen mentioned this pull request Apr 12, 2023
Closed
18 tasks
@heinezen heinezen mentioned this pull request Jun 24, 2023
Closed
13 tasks
@heinezen
Copy link
Member Author

heinezen commented Jul 9, 2023

Resolved by #1515

@heinezen heinezen closed this Jul 9, 2023
@heinezen heinezen deleted the input-controller branch October 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
big stuff High-impact changes, mainly foundation work improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@heinezen