[WIP] Fixed point numbers #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -678,7 +678,7 @@ void ProjectileProducer::initialise(Unit *unit, Player &) { | |||
| unit->graphics = &this->graphics; | |||
|
|
|||
| // projectile speed | |||
| coord::phys_t sp = this->unit_data.speed * coord::settings::phys_per_tile / 666; | |||
| coord::phys_t sp = coord::phys_t{this->unit_data.speed} / 666; | |||
|
This looks pretty nice, so far. A lot of the ugliness that resulted from my earlier hacks has been removed. |
| constexpr FixedPoint() : data(0) { | ||
| } | ||
|
|
||
| constexpr FixedPoint(int_type n) : data(n << fractional_bits) { |
There was a problem hiding this comment.
We probably want those single-argument constructors to be explicit to prevent some implicit conversions.
TheJJ
added
improvement
|
hows this going? are you having problems with the big folder structure change? you want |
Closed
6 tasks
|
superseeded by #662 |
|
went upstream in #975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed point numbers, to replace the int_64 and related calculations on the
phys_ttype. This also removes the uglysettingsnamespace.It compiles, but still has quite some bugs I'm currently fixing (I'll also be moving it to the
utilnamespace).