Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Re-write of the coordinate system #662

Closed
wants to merge 10 commits into from
Closed

[WIP] Re-write of the coordinate system #662

wants to merge 10 commits into from

Conversation

mic-e
Copy link
Member

@mic-e mic-e commented Nov 1, 2016 •
edited by TheJJ

The coordinate system code is arguably one of the most stinky and oldest parts of the C++ codebase and desperately requires a re-write - manual, header-assisted code generation - could you imagine I once thought that was a good idea?

Furthermore it adds new coordinate base classes.

  • Add new fixed-point number type, adapted from [WIP] Fixed point numbers #322, thanks to @detrumi
  • Add tests for the fixed-point number type
  • Add new coordinate system base classes: Coordinate(XY(Z)?|NeSe(Up)?)(Absolute|Relative)
  • Move the coordinate conversion functions from the existing classes to the Engine (or a subsystem thereof)
  • Re-write the existing classes (CamGame, ...) to be based on the Coordinate classes, using the fixed-point number type
  • Update build instructions for new dependencies (jinja2)

closes #56

@mic-e mic-e added improvement Enhancement of an existing component lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Nov 1, 2016
@TheJJ TheJJ mentioned this pull request Nov 13, 2016
Closed
@mic-e mic-e force-pushed the coord branch 5 times, most recently from 73569fc to f6de164 Compare December 31, 2016 09:52
@TheJJ TheJJ mentioned this pull request Jan 2, 2017
Merged
1 task
This was referenced Jan 17, 2017
Closed
Closed
@mic-e mic-e mentioned this pull request Feb 2, 2017
Closed
@zuntrax zuntrax mentioned this pull request Feb 17, 2017
Open
@TheJJ TheJJ mentioned this pull request Feb 18, 2017
Closed
@TheJJ TheJJ mentioned this pull request Apr 4, 2017
Merged
@TheJJ TheJJ added this to the v0.4.0 milestone Apr 5, 2017
castilma pushed a commit to castilma/openage that referenced this pull request Apr 6, 2017
codecompliance: make files codecompliant
856ae41 
This removes 'asdf' from several files to make the compliance check stop
complaining, so that it's possible to merge the asdf-test. mic-e will fix
engine.h in SFTtech#662.
@tusharpm tusharpm mentioned this pull request Jul 2, 2017
Merged
@mic-e mic-e force-pushed the coord branch 2 times, most recently from ee45f51 to e280908 Compare December 10, 2017 22:15
@mic-e mic-e force-pushed the coord branch 2 times, most recently from 3012f40 to d3597d9 Compare December 29, 2017 19:09
@zuntrax zuntrax added the big stuff High-impact changes, mainly foundation work label Jan 21, 2018
@TheJJ TheJJ mentioned this pull request Feb 16, 2018
Merged
@zuntrax zuntrax closed this in #975 Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
big stuff High-impact changes, mainly foundation work code quality Does not alter behavior, but beauty of our code improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

preprocessor-free coordinate system
4 participants
@mic-e @TheJJ @zuntrax @detrumi