Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quit button #990

Merged
merged 1 commit into from
Mar 25, 2018
Merged

Add quit button #990

merged 1 commit into from
Mar 25, 2018

Conversation

samuelgrigolato
Copy link
Contributor

This is a third attempt to #616. It builds upon #620, #621 and this specific @TheJJ's comment:

For this issue, and because we have no server part, I think its enough to just add a button that then calls a function where we can do more complicated things in the future. For now, it can just call Engine::stop().

heinezen
heinezen requested changes Mar 25, 2018
View reviewed changes
copying.md Outdated
@@ -109,6 +109,7 @@ _the openage authors_ are:
| Arne Sellmann | PythonicChemist | arne dawt sellmann à gmx dawt de |
| Rafael X. Morales Georgi | chocoladisco | chocoladisco à gmail dawt com |
| Marcel Schneider | schnema123 | marcelschneider5 à outlook dawt de |
| Samuel Grigolato | samuelgrigolato | samuel dawt grigolato à gmail dawt com |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rightmost border of the table has to line up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@heinezen
Copy link
Member

works for me and should for others as well :)

@heinezen heinezen merged commit 0f184c0 into SFTtech:master Mar 25, 2018
@TheJJ TheJJ mentioned this pull request Apr 10, 2018
Closed
@TheJJ TheJJ added nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code area: ui Related to the graphical user interface (Qt) labels Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen heinezen approved these changes

Assignees
No one assigned
Labels
area: ui Related to the graphical user interface (Qt) lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelgrigolato @heinezen @TheJJ