Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

文件末尾自动添加换行 #58

Closed
zhoudian64 opened this issue Aug 6, 2020 · 3 comments
Closed

文件末尾自动添加换行 #58

zhoudian64 opened this issue Aug 6, 2020 · 3 comments
Labels
efficiency Things to improve developing efficiency feature request A new feature need to be implemented. help wanted Extra attention is needed low priority This is not so important and can be implemented if you have time. medium This issue is not so easy to fix

Comments

@zhoudian64
Copy link

Describe the solution you'd like
所有文件是否需要统一，最后需要一行换行。

Additional context
Github review时能看到非常多的最后没有换行。
@zhoudian64 zhoudian64 added feature request A new feature need to be implemented. help wanted Extra attention is needed low priority This is not so important and can be implemented if you have time. labels Aug 6, 2020
@longfangsong
Copy link
Collaborator

Describe the solution you'd like
所有文件是否需要统一，最后需要一行换行。

Additional context
Github review时能看到非常多的最后没有换行。

实际上我个人是不太在意这个事情的。

不过业界都希望有换行来着。

我建议写(chao)个脚本自动给我们加上换行，然后加到 git hooks 里面每次commit前自动跑。

@longfangsong longfangsong added the medium This issue is not so easy to fix label Aug 6, 2020
@longfangsong longfangsong changed the title 关于文件格式 文件末尾自动添加换行 Aug 6, 2020
@longfangsong longfangsong added the efficiency Things to improve developing efficiency label Aug 7, 2020
@laojianzi
Copy link
Collaborator

如果为了代码和 review 更好的阅读，建议可以考虑添加一些 .editconfig、golangci-lint 等工具来辅助

@longfangsong longfangsong mentioned this issue Sep 2, 2020
Closed
@longfangsong
Copy link
Collaborator

Replaced by #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
efficiency Things to improve developing efficiency feature request A new feature need to be implemented. help wanted Extra attention is needed low priority This is not so important and can be implemented if you have time. medium This issue is not so easy to fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@longfangsong @zhoudian64 @laojianzi