-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pymatgen requiring Python 3.6? #62
Comments
Issue opened on Pymatgen tracker: materialsproject/pymatgen#1522 |
It looks like there is a way to set different dependencies in the sumo setup.py depending on the local Python version. https://www.python.org/dev/peps/pep-0508/#environment-markers As much as I would like to use f-strings, it seems a bit early to drop Python 3.5 for sumo if we can avoid it: many of our users are running sumo on cluster login nodes which have a limited selection of Python modules. |
Pymatgen team has confirmed their move to 3.6 (Issue) and put the requirement in setup.py. We have two options:
Maybe do a numbered 3.5-compatible release of Sumo that pins to an appropriate Pymatgen version, then move further Sumo development to 3.6-only? That way people on 3.5 have a known sumo version number they can safely install. |
I also think Python 3.6 is a little close for comfort. I like the idea of a numbered 3.5 compatible release. |
Closing as the immediate issue has been fixed. We still need to plan a "final 3.5 release" before things diverge too far. |
This build is blowing up because Pymatgen is using f-strings which are only available in very recent Python versions. Should/can we pin Pymatgen to a compatible version in setup.py?
The text was updated successfully, but these errors were encountered: