Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymatgen requiring Python 3.6? #62

Closed
ajjackson opened this issue Jul 5, 2019 · 5 comments
Closed

Pymatgen requiring Python 3.6? #62

ajjackson opened this issue Jul 5, 2019 · 5 comments

Comments

@ajjackson
Copy link
Member

This build is blowing up because Pymatgen is using f-strings which are only available in very recent Python versions. Should/can we pin Pymatgen to a compatible version in setup.py?

@ajjackson
Copy link
Member Author

Issue opened on Pymatgen tracker: materialsproject/pymatgen#1522

@ajjackson
Copy link
Member Author

ajjackson commented Jul 5, 2019

It looks like there is a way to set different dependencies in the sumo setup.py depending on the local Python version. https://www.python.org/dev/peps/pep-0508/#environment-markers

As much as I would like to use f-strings, it seems a bit early to drop Python 3.5 for sumo if we can avoid it: many of our users are running sumo on cluster login nodes which have a limited selection of Python modules.

@ajjackson
Copy link
Member Author

ajjackson commented Jul 7, 2019

Pymatgen team has confirmed their move to 3.6 (Issue) and put the requirement in setup.py.

We have two options:

  • Make Python 3.6 a hard requirement for Sumo as well (as I said in that Issue I think this is ok for our users but it's a bit tight for comfort.)
  • Try and do some setup.py magic to pin 3.5 users to an older version of Pymatgen. This could be unsustainable in the medium term as quite a few bugs/feature-requests in sumo have been addressed by making changes to Pymatgen...

Maybe do a numbered 3.5-compatible release of Sumo that pins to an appropriate Pymatgen version, then move further Sumo development to 3.6-only? That way people on 3.5 have a known sumo version number they can safely install.

@utf
Copy link
Member

utf commented Jul 10, 2019

I also think Python 3.6 is a little close for comfort.

I like the idea of a numbered 3.5 compatible release.

@ajjackson
Copy link
Member Author

ajjackson commented Jul 23, 2019

Closing as the immediate issue has been fixed. We still need to plan a "final 3.5 release" before things diverge too far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants