New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KPLSK is badly implemented #620

Open

Paul-Saves opened this issue Jul 9, 2024 · 0 comments

Contributor

Paul-Saves commented Jul 9, 2024 •

edited

Loading

KPLSK features several implementation issues

First, it is not KPLS+K but KPLS+KPLS
Second, it modify the options settings
Third, it add two nasty booleans in krg_based
Fourth, it is implemented in krg_based, not kplsk.py
Fifth, there is a loop that goes from 0 to -1,which is a weird way of counting
Sixth, KPLSK is not working with eval_n_comp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment