Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOwGLoBES 1.3 Compatibility #201

Closed
Storreslara opened this issue Aug 2, 2022 · 1 comment · Fixed by #229
Closed

SNOwGLoBES 1.3 Compatibility #201

Storreslara opened this issue Aug 2, 2022 · 1 comment · Fixed by #229
Labels
SNOwGLoBES Related to SNOwGLoBES
Milestone

Comments

@Storreslara
Copy link

Currently the channel file structure for custom binning breaks SNEWPY's channel.dat dataframe. This is due to the 'SN_nu' tag put in the beginning of each line (needed to use a the custom binning postamble file ).

To get rid of the SN_nu tag while making the df use the following code

df_chan = pd.read_csv(path_chan, sep=" ", header=None)

if df_chan[0][0] == "SN_nu":
    df_chan.drop(df_chan.columns[0], axis=1, inplace=True)
    
# then you can add the col names.. 
@JostMigenda
Copy link
Member

Another change in the new SNOwGLoBES version is going to be that efficiency and smearing files are in detector-specific subdirectories, so we need to update the file paths in SimpleRate._load_efficiency_vectors() and SimpleRate._load_smearing_matrices() accordingly.

@JostMigenda JostMigenda changed the title SNOwGLoGES 1.3 Compatibility SNOwGLoBES 1.3 Compatibility Aug 2, 2022
@JostMigenda JostMigenda added the SNOwGLoBES Related to SNOwGLoBES label Aug 2, 2022
@JostMigenda JostMigenda added this to the v1.4 milestone Sep 15, 2022
@JostMigenda JostMigenda modified the milestones: v1.4, v1.3 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SNOwGLoBES Related to SNOwGLoBES
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants