Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models: Remove deprecated arguments in constructors #307

Open
4 of 5 tasks
Sheshuk opened this issue Mar 1, 2024 · 0 comments · Fixed by #356
Open
4 of 5 tasks

Models: Remove deprecated arguments in constructors #307

Sheshuk opened this issue Mar 1, 2024 · 0 comments · Fixed by #356
Labels
Change interface Breaking the backward compatibility ModelRegistry Connected to the registry of models
Milestone

Comments

@Sheshuk
Copy link
Contributor

Sheshuk commented Mar 1, 2024

Change the way the models are initialized.

  • Remove all @legacy_filename_initialization decorators in models/ccsn.py
  • Remove all deprecated input parameters
    Remove workarounds for OConnor_2013 model:
  • Remove class OConnor_2013
  • Rename class _OConnor_2013_new to OConnor_2013
  • Remove lines with workaround for ModelsTable and documentation:
    OConnor_2013.__init__.__doc__=dedent(OConnor_2013.__init__.__doc__)+_OConnor_2013_new.__init__.__doc__
    #make sure that only the latest class is present in the models table
    all_models.remove(OConnor_2013.__mro__[1])
    all_models.add(OConnor_2013)
@Sheshuk Sheshuk added this to the v2.0 milestone Mar 1, 2024
@Sheshuk Sheshuk added ModelRegistry Connected to the registry of models Change interface Breaking the backward compatibility labels Mar 1, 2024
@Sheshuk Sheshuk linked a pull request Aug 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change interface Breaking the backward compatibility ModelRegistry Connected to the registry of models
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant