Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The job is still successful after the task fails #36

Closed
uedring opened this issue Mar 17, 2021 · 2 comments
Closed

The job is still successful after the task fails #36

uedring opened this issue Mar 17, 2021 · 2 comments
Assignees
@NowinskiK
Labels
bug Something isn't working

Comments

@uedring
Copy link

uedring commented Mar 17, 2021

I have a Build Pipeline with only one job and continueOnError is set to false, but after the Build ADF Task fails, the job status is still successful. How can this be resolved?

Here is the yml:

trigger: none

continueOnError: false

pool:
  vmImage: 'windows-latest'

variables:
  factoryName: 'TargetingDataFactory'

steps:
    - task: BuildADFTask@1
      inputs:
        DataFactoryCodePath: '$(factoryName)'
        Action: 'Build'

image
@NowinskiK NowinskiK self-assigned this Mar 18, 2021
@NowinskiK NowinskiK added the triage Issue is under investigation label Mar 18, 2021
@uedring uedring closed this as completed Mar 25, 2021
@NowinskiK
Copy link
Member

hey @uedring, why do you close the issue? I'm going to look at this.

@uedring uedring reopened this Mar 30, 2021
@NowinskiK NowinskiK added bug Something isn't working and removed triage Issue is under investigation labels Apr 21, 2021
NowinskiK added a commit that referenced this issue Apr 21, 2021
@NowinskiK
#36 Build task fails when any error is found
2a25cf3
@NowinskiK NowinskiK mentioned this issue Apr 21, 2021
Merged
NowinskiK added a commit that referenced this issue Apr 21, 2021
@NowinskiK
Merge pull request #43 from SQLPlayer/bug-36
c3e45d2 
#36 Build task fails when any error is found
@NowinskiK
Copy link
Member

@uedring , this is fixed now in ver.1.6.
Thanks for raising this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NowinskiK NowinskiK

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NowinskiK @uedring