Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install is broken #7

Closed
loicgelle opened this issue Jul 5, 2017 · 10 comments
Closed

Install is broken #7

loicgelle opened this issue Jul 5, 2017 · 10 comments

Comments

@loicgelle
Copy link
Contributor

As stated in the readme, install is broken. I would suggest that major changes like this take place in a different branch, and are merged once everything is fixed. It made my Docker package builds fail

@ianamason

@ianamason
Copy link
Member

ianamason commented Jul 5, 2017 via email

@loicgelle
Copy link
Contributor Author

I was talking about the first install. git clone ... does not work anymore, you have to clone into GOPATH/src/github.com/SRI-CSL.

Not a big deal to fix but it is quite a change

@ianamason
Copy link
Member

ianamason commented Jul 5, 2017 via email

@loicgelle
Copy link
Contributor Author

@ianamason I still leave the issue open as a remainder to fix the README definitely

@ianamason
Copy link
Member

Yes please. Why do you need to clone in docker? can't you do the "go get"s and
let them do it for you?

@loicgelle
Copy link
Contributor Author

This is what I am doing now indeed

@ianamason
Copy link
Member

well if you look at the imports in the executable files, you see why go forces us to
do it this way.

@loicgelle
Copy link
Contributor Author

@ianamason I know that, I struggled to understand their weird import system at first

@ianamason
Copy link
Member

I will close this when the README.md is polished up.

@ianamason
Copy link
Member

Thanks Loic for the environmment fixes. Bruno and I will rewrite the README.md,
then I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants