-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The system cannot find the file specified. #21
Comments
The docs made it seem like
|
@cmoody I think there is a case that escaped from the tests I wrote while preparing the github action. It may be related to path lengths or some characters. I will do extra tests and get back to you. |
Could the version of the JDK be the problem?
Downloading that same JDK locally, I see |
@cmoody I could not reproduce the problem you experienced. However, I made an update to a part that might cause the problem. Can you try signing again with the latest version in the develop branch? |
I added debug logging to see if that gives us a little more insight. Ultimately looks like the same issue.
|
@bayrakmustafa when you are running your tests are you setting the Java Version as part of the build? https://www.ssl.com/how-to/cloud-code-signing-integration-with-github-actions/ has an |
@cmoody There is a test I wrote at https://github.com/SSLcom/esigner-codesign/blob/develop/.github/workflows/test.yml#L133. Actually, I don't do anything different from you. It comes with Java in Windows setup. There shouldn't be a situation where the signing command cannot find Java because it uses that Java. I will change the signing command. I will update to use the Java I just installed, not the Java in the Windows setup. I will inform you again when the update is done. |
@cmoody I updated a few places where there might be problems. I also added a log for windows. Can you test the latest version in the develop branch by adding the following parameter?
|
@bayrakmustafa same issue
|
I've been helping @cmoody debug this and even forked the GH action, which has lead me to believe it is one of the arguments with the paths, but I'm not sure which one/why. Changing the command that gets executed from
and
Would it be possible for the Java code to print the path that is not found, so that we can confirm it's not an issue with backslashes/quotes being translated incorrectly? |
I added a check within the JS wrapper to see if the
and the input file does exist at that point:
I was careful to do the |
@bayrakmustafa I did try something that was interesting. I copied the creation of that ps1 file and then tried to sign it. Got the same results.
I thought maybe it was node versions so Ive checked those. Nothing looks too different there. The only thing I changed really was this Im going to fork the repo tonight and try to see if I can recreate the same failure to help narrow this down. |
@cmoody I tested the yml file you sent by converting it to the figure below, and I still had no problems. There seems to be a very interesting situation. Can you test it with the yml below? I also made an update to the signing command. Could you try again by adding
|
Truly stumped. I created a new workflow with just what you have above and get the same error.
|
@cmoody Can you share the full log after adding the |
|
@cmoody I couldn't find anything about the problem. I didn't experience any problems in my own tests. Could you please try creating a repo from scratch and testing it there? It might be something to do with the repo name or anything else, I'm not sure. Truly stumped |
@cmoody I forked your project. You can look at https://github.com/bayrakmustafa/civitai-link-desktop. I was able to build successfully and sign the exe file. If you want, you can examine the yml file. I didn't experience any problems. Does your problem still persist? |
@bayrakmustafa sorry for the late reply. I started signing locally just to get launched. The only thing thats changed is I made the repo public since its going to be open source. Would there be an issue with that difference? |
@cmoody When I check civitai/civitai-link-desktop#13 I see that you are still having problems. I forked the test branch and tested again. Unfortunately, I'm okay with it too. Please, there is a yml file containing demo user information at https://github.com/bayrakmustafa/civitai-link-desktop/blob/test/.github/workflows/release.yml. Can you test with this file? Maybe there is something wrong with environment_name being PROD. |
civitai/civitai-link-desktop#15 Looks like all of that works. Is there a setting in ssl.com for environment or is it just based on the type of ssl cert you get? |
@cmoody I added you as an authorized person to the https://github.com/eSignerCKA/civitai-link-desktop repo. Do you have a chance to change the secret values at https://github.com/eSignerCKA/civitai-link-desktop/settings/secrets/actions with information about your own prod certificate? Since you will write it in Secrets, I will not have the chance to see these values. Once we detect and fix the problem, we delete the repo. |
@bayrakmustafa sorry for the delay. Been working around everything manually so we can get a build out but am back to start looking at this. Ive gone ahead and added everything to the secrets on that repo. |
@cmoody It's not important. I started working to solve the problem |
@cmoody I think I've identified the problem. But I haven't found a solution yet. The problem seems to be caused by special characters in the SSL.com account password. For a quick solution, you can reset your SSL.com account password. If you set a new password by paying attention to special characters, your problem will be solved. If you can then send your old password to mustafa.bayrak@windowslive.com, I will work on the special characters in the password. |
@cmoody I solved the problem. Can you test again? (https://github.com/eSignerCKA/civitai-link-desktop/actions/runs/8529193622/job/23364439496) |
Looks like the signing step is working now! Thanks for the help. https://github.com/civitai/civitai-link-desktop/actions/runs/8529787442/job/23366275422 its failing because of another step but the signing step looks to be good. |
Looks like the code signing is "successful" in that the process works and it says it was successful but when you go to download the exe its not signed. https://github.com/civitai/civitai-link-desktop/actions/runs/8607582442/job/23588337302 |
@cmoody I checked the exe file by adding the upload process at https://github.com/eSignerCKA/civitai-link-desktop/actions/runs/8638202336. You can download and check the uploaded file from the artifacts section. It appears signed. Can you check the step where you upload the signed file? Could you be working with the wrong file? |
Hi, it seems the bug is very obvious, in your latest 1.3.1 windows version, the folder does not contain the jdk at all... |
@niudai Which link did you download from? Can you try by downloading it from https://github.com/SSLcom/CodeSignTool/releases/download/v1.3.1/CodeSignTool-v1.3.1-windows.zip? It's in the jdk. |
I am building an Electron app. I have a github workflow that works to build apps. I am now trying to add in the code signing step. Everything looks correct, including the outputs for where files are. However once it gets to the point to run
CodeSignTool.bat
it fails. Im hoping I am just overlooking a simple path or name.Github Workflow
Sign Artifact with CodeSignTool
I even added a step before to list on files in the directory. I saw all of the built Windows files but still get
The system cannot find the file specified.
The text was updated successfully, but these errors were encountered: