Document ad_access_filter search for nested groups

[taupehat]

Short doc fix and example to demonstrate how to ensure ad_access_filter includes nested group membership.

[centos-ci]

Can one of the admins verify this patch?

[centos-ci]

Can one of the admins verify this patch?

[jhrozek]

ok to test

[sumit-bose]

Thank you for the patch. Given the related discussion in ticket https://fedorahosted.org/sssd/ticket/3218 I think it would help if you can add a sentence saying that becasue of the ':' characters in the filter part the option must always use the full format with DOM or FOREST and the name.

[jhrozek]

Additionally, if there is some link to MSDN explaining what the OID is, it would be nice to add that link

[abbra]

Please use this URL: https://msdn.microsoft.com/en-us/library/cc223367.aspx

[taupehat]

Could we get a rebuild on this? The previous failed with an error indicating trouble with the build host:
make-intgcheck: Write failed: Broken pipe

[code-with-amitk]

On latest clone of project.

make intgcheck

checking for style of include used by make... GNU
checking whether make supports nested variables... yes
configure: error: source directory already configured; run "make distclean" there first
Makefile:27077: recipe for target 'intgcheck-prepare' failed
make: *** [intgcheck-prepare] Error 1

[lslebodn]

retest this please

[code-with-amitk]

Thanks Islebodn ..... Conflicts are resolved..
Posting What I did may help some one.

Steps for

1. Getting source Code
2. Doing Code Changes
3. Running Integration Tests...
   [root@dlp] dnf -y install git
   [root@dlp] git config --global user.name "GIVENNAME SURNAME"
   [root@dlp] git config --global user.email "username@domain.com"
   [root@dlp] git config --global color.ui auto //Enable Syntax highlighting
   [root@dlp] dnf -y install meld //Tool for resolving Merge conflicts
   [root@dlp] git config --global merge.tool meld
   [root@dlp]# git clone https://git.fedorahosted.org/git/sssd.git
   [root@dlp]# cd sssd
   [root@dlp sssd]# . contrib/fedora/bashrc_sssd
   [root@dlp sssd]# dnf -y install rpm-build dnf-plugins-core libldb-devel
   [root@dlp sssd]# contrib/fedora/make_srpm.sh //Create source rpm
   [root@dlp sssd]# dnf builddep rpmbuild/SRPMS/sssd-*.src.rpm //Install sssd dependencies
   [root@dlp sssd]# reconfig && chmake
   make[1]: Leaving directory '/root/sssd/x86_64'
   [root@dlp x86_64]# pwd <=See Directory Changed Automatically
   /root/sssd/x86_64
   [root@dlp x86_64]#
   [root@dlp x86_64]# dnf install -y openldap-servers fakeroot
   [root@dlp x86_64]# vim ../src/providers/ipa/access_ipa.c
   //Do some changes...
   [root@dlp x86_64]# make
   [root@dlp x86_64]# make intgcheck
   =========== 119 passed in 302.77 seconds ===
   make[1]: Leaving directory '/root/sssd/x86_64'
   [root@dlp x86_64]#

[jhrozek]

The documentation now looks correct, I just wonder why did you remove the example paragraph in the last iteration of the patch? IMO it would be useful..

[sumit-bose]

Just a small nitpick. Can you put the URL into a element like e.g. in https://github.com/SSSD/sssd/blob/master/src/man/sssd-ldap.5.xml#L1047 ? This will make sure the URL is formatted correctly with different output format.

[taupehat]

@jhrozek I did not intend to remove anything from the last iteration. It's possible that I used the editor wrong. Do I need to delete the prior pull request and just create a new one with all changes in place?

[jhrozek]

On Thu, Oct 27, 2016 at 08:48:46AM -0700, taupehat wrote:

@jhrozek I did not intend to remove anything from the last iteration. It's possible that I used the editor wrong. Do I need to delete the prior pull request and just create a new one with all changes in place?

I normally just update the old commit and force-push the branch, github
should be able to pick up the changes. Like this:

vi path/to/file

hack, hack, hack

try to build the manpage with "make" to be sure the XML validates

when finished:

git add /path/to/file
git commit --amend
git push $yourgithubfork $yourbranch --force

[sumit-bose]

Thank you for the patch, ACK

[jhrozek]

master: cf5357a
sssd-1-14: e1c2aea

If any of the maintainers think we should apply the patch to sssd-1-13 as well, please just cherry-pick the patch.