[PATCHES] sss_user/groupmod fixes

[mzidek-gh]

Hi,

This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes fix for the ticket https://fedorahosted.org/sssd/ticket/3178.

Michal

[spbnick]

Just a hint: if you avoid putting "PR" in front of the PR#16, then you'll get a link to the actual pull request on the GitHub page, plus the target pull request will have a link back. Like this: #16.

[mzidek-gh]

Thanks for the tip Nick.

[lslebodn]

On (07/09/16 07:18), mzidek-rh wrote:

Hi,

This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes fix for the ticket https://fedorahosted.org/sssd/ticket/3178.

Michal
You can view, comment on, or merge this pull request online at:

#18

6th patch
src/tools/tools_mc_util.c
if (ret != EOK) {
DEBUG(SSSDBG_MINOR_FAILURE, "Malformed DN [%s]? Skipping\n",
(const char *) el->values[i].data);

•        talloc_free(parent_name);
  

•        talloc_free(parent_internal_name);
       continue;
   }
  

•    ret = sss_mc_refresh_group(parent_name);
  

•    talloc_free(parent_name);
  

•    ret = sss_parse_internal_fqname(tmpctx, parent_internal_name,
  

•                                    &parent_shortname, NULL);
   we should use sss_output_name here
  

•    if (ret != EOK) {
  

•        DEBUG(SSSDBG_MINOR_FAILURE, "Could not parse name %s\n",
  

•              parent_internal_name);
  

•        goto done;
  

•    }
  

•    ret = sss_mc_refresh_group(parent_shortname);
  

•    talloc_free(parent_internal_name);
  

•    talloc_free(parent_shortname);
  

otherwise LGTM

LS

[fidencio]

A few minors in the commit messages that should be fixed before pushing.

Patch0001: TOOLS: Fix a typo in groupadd()
Remove the four spaces before the link of the trac ticket.

Patch0002: TOOLS: sss_groupshow did not work
Patch0003: TESTS: sss_groupadd/groupshow regressions
Patch0004: TOOLS: use internal fqdn for DN
Patch0006: TOOLS: sss_mc_refresh_nested_group short/fqname usage
Patch0007: TESTS: Add FQDN variants for some tests
Use (but do not exceed) 72 characters in the commit (body) message. I have the feeling you're breaking the line with 52.

[lslebodn]

On (07/09/16 09:51), fidencio wrote:

A few minors in the commit messages that should be fixed before pushing.

Patch0001: TOOLS: Fix a typo in groupadd()
Remove the four spaces before the link of the trac ticket.

Patch0002: TOOLS: sss_groupshow did not work
Patch0003: TESTS: sss_groupadd/groupshow regressions
Patch0004: TOOLS: use internal fqdn for DN
Patch0006: TOOLS: sss_mc_refresh_nested_group short/fqname usage
Patch0007: TESTS: Add FQDN variants for some tests
Use (but do not exceed) 72 characters in the commit (body) message. I have the feeling you're breaking the line with 52.

Changed together with adding review-by

ACK

http://sssd-ci.duckdns.org/logs/job/53/01/summary.html

master:

• f2d1d90
• cb54dba
• 7fa4964
• 5e2142b
• 20c2d76
• 5210c5d
• 6be723a

LS