Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependeny on Nancy, update to Netcore 3.1 and Move to Carter #104

Closed
17 of 19 tasks
samatstariongroup opened this issue Mar 15, 2020 · 0 comments
Closed
17 of 19 tasks

Comments

@samatstariongroup
Copy link
Member

samatstariongroup commented Mar 15, 2020

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am running the latest version of the CDP4 Web Services
  • I have searched open and closed issues to ensure it has not already been reported

Description

Nancy is not being maintained anymore. Since we need to move to .netcore 3.1 I propose we stop using Nancy and move to Carter. The following should be looked at:

  • replace nancy with carter
  • let sub projects target netstandard
  • update dependencies such as autofac etc. to be inline with netcore3.1
  • refactor use of config.json to appsettings to follow netcore standard practice
  • add CDP4/COMET specific headers
  • verify routing
  • refactor annex c3 export capability to take permission handling and obfuscation into account
  • expected errors (like unauthorized or notfound etc) should not be returned as a HttpStatusCode.InternalServerError (fix also in integration test suite)
  • refactor LDAP authentication on enterprise edition to make use of newer ldap package that is compatible with net8 #298
  • implement async-await for DAO and service layer (generate) -> not implemented right now. We may revisit when we notice that performance is an issue.
  • regenerate all code to replace CDP4 with COMET
  • favicon
  • refactor SQL logging - remove use of ICommandLogger and remove setting from apssettings and coniguration
  • implement logging abstractions
  • add IIS implementation #293
  • add landing page

see also #261

NancyFx/Nancy#3010

Steps to Reproduce

NA

System Configuration

  • CDP4 Web Services version: 5.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants