Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate segmented algorithms for adjacent_find #5218

Merged

Conversation

Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Mar 2, 2021

Seperate segmented algorithms for adjacent_find

Any background context you want to provide?
Issue #5156

@jenkins-cscs
Copy link
Collaborator

Can one of the admins verify this patch?

@Jedi18 Jedi18 force-pushed the seperate_segmented_adjacent_find branch from ed3c7c3 to 30f1192 Compare March 2, 2021 15:47
@aurianer
Copy link
Contributor

aurianer commented Mar 3, 2021

retest

@hkaiser
Copy link
Member

hkaiser commented Mar 6, 2021

retest cscs

aurianer
aurianer previously approved these changes Mar 8, 2021
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot! 2 minor suggestions but it's not a big deal if it doesn't go into this PR :)

…hm works properly with upcoming sentinel changes
Copy link
Member

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@msimberg
Copy link
Contributor

msimberg commented Mar 9, 2021

retest

@msimberg msimberg merged commit 2c58cc8 into STEllAR-GROUP:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants