Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt transform_exclusive_scan to C++ 20 #5440

Merged
merged 7 commits into from Jul 30, 2021

Conversation

@Jedi18
Copy link
Contributor

@Jedi18 Jedi18 commented Jul 10, 2021

Adapted transform_exclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.

Any background context you want to provide?

Issue #4822
Issue #3646
Issue #1668
Issue #5156

Copy link
Member

@hkaiser hkaiser left a comment

Otherwise, LGTM, thanks a lot!

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_transform_exclusive_scan branch from a5c2a01 to dfeb333 Jul 25, 2021
@jenkins-cscs
Copy link
Collaborator

@jenkins-cscs jenkins-cscs commented Jul 26, 2021

Can one of the admins verify this patch?

Copy link
Member

@hkaiser hkaiser left a comment

LGTM, thanks!

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_transform_exclusive_scan branch from dfeb333 to 3e90633 Jul 30, 2021
@Jedi18
Copy link
Contributor Author

@Jedi18 Jedi18 commented Jul 30, 2021

Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan

@Jedi18 Jedi18 force-pushed the Jedi18:adapt_transform_exclusive_scan branch from 3e90633 to adc8776 Jul 30, 2021
@hkaiser hkaiser merged commit 544406c into STEllAR-GROUP:master Jul 30, 2021
6 of 8 checks passed
6 of 8 checks passed
@github-actions
build build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@github-actions
build
Details
@circleci-checks
build-and-test Workflow: build-and-test
Details
Standard Algorithms automation moved this from Open Tickets to Merged to master Jul 30, 2021
@hkaiser hkaiser mentioned this pull request Jul 30, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants