Adapt transform_exclusive_scan to C++ 20#5440
Merged
hkaiser merged 7 commits intoSTEllAR-GROUP:masterfrom Jul 30, 2021
Merged
Conversation
Jedi18
requested review from
aurianer,
biddisco,
hkaiser and
msimberg
as code owners
This was referenced Jul 13, 2021
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_exclusive_scan.hpp
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
libs/parallelism/algorithms/include/hpx/parallel/algorithms/transform_exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
reviewed
Jul 22, 2021
...arallelism/algorithms/include/hpx/parallel/container_algorithms/transform_exclusive_scan.hpp
Show resolved
Hide resolved
hkaiser
reviewed
Jul 23, 2021
...arallelism/algorithms/include/hpx/parallel/container_algorithms/transform_exclusive_scan.hpp
Outdated
Show resolved
Hide resolved
hkaiser
previously approved these changes
Jul 23, 2021
Member
hkaiser
left a comment
hkaiser
left a comment
There was a problem hiding this comment.
Otherwise, LGTM, thanks a lot!
Jedi18
force-pushed
the
adapt_transform_exclusive_scan
branch
from
a5c2a01 to
dfeb333
Compare
|
Can one of the admins verify this patch? |
Jedi18
force-pushed
the
adapt_transform_exclusive_scan
branch
from
dfeb333 to
3e90633
Compare
Contributor
Author
|
Merge order - exlcusive_scan -> transform_exclusive_scan -> tranform_inclusive_scan |
Jedi18
force-pushed
the
adapt_transform_exclusive_scan
branch
from
3e90633 to
adc8776
Compare
msimberg
pushed a commit
that referenced
this pull request
Aug 6, 2021
Adapt transform_exclusive_scan to C++ 20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted transform_exclusive_scan to C++ 20 and added container overloads. (range and sentinel). Added container tests. Seperated segmented overloads.
Any background context you want to provide?
Issue #4822
Issue #3646
Issue #1668
Issue #5156