A method for every single openstack command?

[thutterer]

Only a few commands have been implemented so far:
993baf2
48519ca
But we already have code duplications and differences:
ab689c1
And looking at the length of the list of openstack commands, we should consider a more generic way to implement these helpers, e.g. the code for listing users and images is basically the same and should be reusable when I want to list tenants (projects).

[vmoravec]

In general I agree with you, I just did not want to optimize these things too early and too much as we have currently only 2 openstackclient commands covered.

[thutterer]

Yes, but I'd need project now and the necessary code for introducing openstack project list or show functionality would be only duplication.
Those to sub-commands should be inherited from some parent class, don't you think?

[vmoravec]

Or module that is included into the context. We're already including NodeContext into the commands classes, we might add them there (or into a new module that is included into the NodeContext): https://github.com/SUSE-Cloud/cct/blob/master/lib/cct/commands/openstack.rb#L22

Or would you rather convert that module into a class and inherit from it for every openstackclient command (I mean here this class: https://github.com/SUSE-Cloud/cct/blob/master/lib/cct/commands/openstack/user.rb#L4) ?

[thutterer]

Puh, that's a design questions on which I don't have any particular opinion.

[vmoravec]

This is the proposal to simpify the commands' implementation: Add openstack client refactored api

[thutterer]

Thanks for improving this right away!

Edit: I just saw the PR isn't merged yet but I keep this issue closed as this will eventually go into master.