Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

translation missing: en.devise.failure.user.ldap_bind_failed #1774

Closed
draeron opened this issue Apr 9, 2018 · 2 comments · Fixed by #1817
Closed

translation missing: en.devise.failure.user.ldap_bind_failed #1774

draeron opened this issue Apr 9, 2018 · 2 comments · Fixed by #1817
Assignees
@mssola
Labels
bug duplicate

Comments

@draeron
Copy link

draeron commented Apr 9, 2018

Description

Missing proper error message with ldap. Please not, this not about ldap login working or not, just the error message when portus is misconfigured.

Steps to reproduce

  1. Enter invalid bind information in
  2. Try to login
  3. Missing error message.
  • Expected behavior: Get some error / tip which might help finding what is misconfigured
  • Actual behavior: got a translation label id

Deployment information

Deployment method: helm chart, v0.1.0
Configuration:

ldap:
  enabled: true

  hostname: "*****"
  port: 636

  # Available options: "plain", "simple_tls" and "starttls". The default is
  # "plain", the recommended is "starttls".
  method: simple_tls

  # The base where users are located (e.g. "ou=users,dc=example,dc=com").
  base: "OU=Users,DC=****,DC=com"

  # User filter (e.g. "mail=george*").
  filter: "(objectClass=person)"

  # The LDAP attribute where to search for username. The default is 'uid'.
  uid: "sAMAccountName"

  # LDAP credentials used to search for a user.
  authentication:
    enabled: true
    bind_dn: ****
    password: *****
  guess_email:
    enabled: false
    attr:

Portus version: 2.3
@yongzhang
Copy link

#1746

@mssola
Copy link
Collaborator

mssola commented May 2, 2018

as @hiscal2015 points out, it looks like a duplicate of #1746. I'll keep this open though.

@mssola mssola self-assigned this May 2, 2018
mssola added a commit to mssola/Portus that referenced this issue May 10, 2018
@mssola
ldap: fixed a couple of bugs around SSL support
2c559f4 
This commit fixes a couple of bugs present in both master and 2.3:

1. We didn't implement some options that needed to be passed to the LDAP
   backend to fully support SSL connections. This has been addressed
   also in the configuration, but without breaking existing
   installations (e.g. the `method` attribute from 2.3 has been left
   untouched). This will be addressed in later commits of the master
   branch (so in 2.4 users should adapt to this change).
2. We were relying on Devise's translations for failures, but some of
   them were not available. This has been addressed and improved: the
   error message will be more on point and more informative to end
   users.

There is still room for improvement, but we can do it in later commits:
let's keep this commit to the point so it can be cherry-picked into the
2.3 branch.

Fixes SUSE#1746
Fixes SUSE#1774

bsc#1073232

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@mssola mssola mentioned this issue May 10, 2018
Merged
mssola added a commit to mssola/Portus that referenced this issue May 11, 2018
@mssola
ldap: fixed a couple of bugs around SSL support
fd8df5c 
This commit fixes a couple of bugs present in both master and 2.3:

1. We didn't implement some options that needed to be passed to the LDAP
   backend to fully support SSL connections. This has been addressed
   also in the configuration, but without breaking existing
   installations (e.g. the `method` attribute from 2.3 has been left
   untouched). This will be addressed in later commits of the master
   branch (so in 2.4 users should adapt to this change).
2. We were relying on Devise's translations for failures, but some of
   them were not available. This has been addressed and improved: the
   error message will be more on point and more informative to end
   users.

There is still room for improvement, but we can do it in later commits:
let's keep this commit to the point so it can be cherry-picked into the
2.3 branch.

Fixes SUSE#1746
Fixes SUSE#1774

bsc#1073232

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola added a commit to mssola/Portus that referenced this issue May 11, 2018
@mssola
ldap: fixed a couple of bugs around SSL support
e42dedf 
This commit fixes a couple of bugs present in both master and 2.3:

1. We didn't implement some options that needed to be passed to the LDAP
   backend to fully support SSL connections. This has been addressed
   also in the configuration, but without breaking existing
   installations (e.g. the `method` attribute from 2.3 has been left
   untouched). This will be addressed in later commits of the master
   branch (so in 2.4 users should adapt to this change).
2. We were relying on Devise's translations for failures, but some of
   them were not available. This has been addressed and improved: the
   error message will be more on point and more informative to end
   users.

There is still room for improvement, but we can do it in later commits:
let's keep this commit to the point so it can be cherry-picked into the
2.3 branch.

Fixes SUSE#1746
Fixes SUSE#1774

bsc#1073232

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola added a commit to mssola/Portus that referenced this issue May 11, 2018
@mssola
ldap: fixed a couple of bugs around SSL support
ae80df2 
This commit fixes a couple of bugs present in both master and 2.3:

1. We didn't implement some options that needed to be passed to the LDAP
   backend to fully support SSL connections. This has been addressed
   also in the configuration, but without breaking existing
   installations (e.g. the `method` attribute from 2.3 has been left
   untouched). This will be addressed in later commits of the master
   branch (so in 2.4 users should adapt to this change).
2. We were relying on Devise's translations for failures, but some of
   them were not available. This has been addressed and improved: the
   error message will be more on point and more informative to end
   users.

There is still room for improvement, but we can do it in later commits:
let's keep this commit to the point so it can be cherry-picked into the
2.3 branch.

Fixes SUSE#1746
Fixes SUSE#1774

bsc#1073232

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola added a commit that referenced this issue May 11, 2018
@mssola
ldap: fixed a couple of bugs around SSL support
4892eb1 
This commit fixes a couple of bugs present in both master and 2.3:

1. We didn't implement some options that needed to be passed to the LDAP
   backend to fully support SSL connections. This has been addressed
   also in the configuration, but without breaking existing
   installations (e.g. the `method` attribute from 2.3 has been left
   untouched). This will be addressed in later commits of the master
   branch (so in 2.4 users should adapt to this change).
2. We were relying on Devise's translations for failures, but some of
   them were not available. This has been addressed and improved: the
   error message will be more on point and more informative to end
   users.

There is still room for improvement, but we can do it in later commits:
let's keep this commit to the point so it can be cherry-picked into the
2.3 branch.

Fixes #1746
Fixes #1774

bsc#1073232

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
vitoravelino pushed a commit to vitoravelino/Portus that referenced this issue May 16, 2018
@mssola
ldap: fixed a couple of bugs around SSL support
1282bfe 
This commit fixes a couple of bugs present in both master and 2.3:

1. We didn't implement some options that needed to be passed to the LDAP
   backend to fully support SSL connections. This has been addressed
   also in the configuration, but without breaking existing
   installations (e.g. the `method` attribute from 2.3 has been left
   untouched). This will be addressed in later commits of the master
   branch (so in 2.4 users should adapt to this change).
2. We were relying on Devise's translations for failures, but some of
   them were not available. This has been addressed and improved: the
   error message will be more on point and more informative to end
   users.

There is still room for improvement, but we can do it in later commits:
let's keep this commit to the point so it can be cherry-picked into the
2.3 branch.

Fixes SUSE#1746
Fixes SUSE#1774

bsc#1073232

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mssola mssola

Labels
bug duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ldap: fixed a couple of bugs around SSL support mssola/Portus
3 participants
@mssola @draeron @yongzhang