This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Ui second iteration #445
Merged
Ui second iteration #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call-to-action. No other buttons should be used. Everything put inside a Panel to be consistens with the whole interface
…he variables.less file
…g the Vendor files... bad bad. Also, removed the duplicated values in the variables.scss of Portus
Conflicts: app/views/admin/registries/new.html.slim
|
Just wow, that is amazing! 👏 @mssola please tell me we can merge it immediately, I'm just about to make take some screenshots of Portus and I would like them to be based on the new theme |
|
I'm not really a fronted developer, but the code changes look fine to me. We just have to fix the build failures. I think this can be done immediately after the merge |
|
@flavio thank you Flavio :) |
…t intuitive for a user to not see the link and think it will appear on screen once he types a wrong password
|
@flavio LGTM 👏 |
|
I like it a lot! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from the big list of fixes requested at https://etherpad.nue.suse.com/p/design-portus
Some screenshots: