Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SES6 initial build #168

Closed
wants to merge 22 commits into from
Closed

SES6 initial build #168

wants to merge 22 commits into from

Conversation

smithfarm
Copy link

@smithfarm smithfarm commented Nov 24, 2017 •
edited
Loading

tchaikov and others added 6 commits November 18, 2017 14:05
@tchaikov
rpm: add cunit-devel for 'suse_version'
1ac89cb 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@smithfarm
build/ops: rpm: fix systemd macros for ceph-volume@.service
d1f2df3 
Fixes: http://tracker.ceph.com/issues/22217
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@tchaikov
msg/simple: pass a char for reading from shutdown_rd_fd
fd3c5cf 
Fixes the coverity issue:

> CID 1395794 (#1 of 1): Wrong size argument (SIZEOF_MISMATCH)
> suspicious_sizeof: Passing argument &ch of type int * and
> argument 1UL to function read is suspicious because sizeof
> (int) /*4*/ is expected.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
osd: use prefix increment for non trivial iterator
a027dae 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
make-dist: repackage boost in the correct path
2218efa 
before this change, boost is put into ./src. after this change, it is
put into $outfile/src. i.e. something like
ceph-12.1.2-4592-gf5f2ced624/src .

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
cmake: check bootstrap.sh instead before downloading boost
e3b703e 
config.hpp does not exist if boost is not configured. so a boost source
directory unpacked from dist tarball does not have this file. the
bootstrap.sh instead, it is used to create the necessary config files
for jam.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov
mon/OSDMonitor: add space after __func__ in log msg
d634a5d 
Signed-off-by: Kefu Chai <kchai@redhat.com>
xiexingguo and others added 2 commits November 24, 2017 17:52
@xiexingguo
Merge pull request ceph#19127 from tchaikov/wip-mon-better-logging
23f69ac 
mon/OSDMonitor: add space after __func__ in log msg

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
@tchaikov
make-dist: exclude unused bits in boost
65f9122 
the docs, examples and tests are not used. so drop them. we could go
further by removing unused components in boost. but that'd be an issue
if somebody added a component in CMakeLists but forgets to update this
script. also, we need to remove boost/$component and lib/$component to
achieve this goal. this also introduces extra complicity. so leave it
for another change.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@smithfarm smithfarm force-pushed the wip-ses6-initial-build branch 3 times, most recently from fe6f1a6 to 5135cf0 Compare November 24, 2017 14:04
@smithfarm
Copy link
Author

Wow, sorry - I wasn't expecting there to be so much additional work, but this branch should now build successfully in OBS [1] so it's "safe" to review now!

[1] https://build.opensuse.org/package/show/filesystems:ceph:mimic/ceph

@smithfarm
Merge pull request ceph#18997 from tchaikov/wip-rpm-cunit-for-suse
267a145 
rpm: build-depends on "cunit-devel" for suse

Reviewed-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Boris Ranto <branto@redhat.com>
tchaikov and others added 5 commits November 24, 2017 23:48
@tchaikov
Merge pull request ceph#19094 from tchaikov/wip-coverity-cid-1395794
60e8cd6 
msg/simple: pass a char for reading from shutdown_rd_fd

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
@tchaikov
Merge pull request ceph#19097 from tchaikov/wip-osd-prefix-inc
a769b82 
osd: use prefix increment for non trivial iterator

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
@tchaikov
Merge pull request ceph#19081 from smithfarm/wip-ceph-volume-spec
54b528b 
build/ops: rpm: fix systemd macros for ceph-volume@.service

Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Boris Ranto <branto@redhat.com>
@tchaikov
Merge pull request ceph#19124 from tchaikov/wip-make-dist-boost
e984538 
make-dist,cmake: avoid re-downloading boost

Reviewed-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: rpm: make lowmem_builder code much smarter
eca5dc6 
Credits to Tomas Chvatal

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: rpm: put OBS-specific code in suse_version block
1a271f9 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: rpm: disable java build on SUSE
b305bf2 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: rpm: move parallel build section before cmake
a8d98ab 
Because cmake now uses this setting for the boost build, we need to compute the
build parallelism before running cmake, instead of after.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: cmake: do not guard certain tools with WITH_TESTS
104a28c 
As a follow-up to d7b493a we need to stop guarding

    ceph-osdomap-tool
    ceph-monstore-tool
    ceph-kvstore-tool

with WITH_TESTS because they have been moved out of the ceph-test package.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: rpm: enable lowmem_builder bcond for SUSE only
bf28399 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
build/ops: rpm: lttng build on SLES only for certain architectures
5318143 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
cmake: set empty-string RPATH for libceph_zstd.so.2.0.0
d177e18 
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm smithfarm closed this Nov 25, 2017
@smithfarm smithfarm deleted the wip-ses6-initial-build branch November 26, 2017 11:17
@smithfarm
Copy link
Author

Work on this continues in #171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tserong tserong tserong approved these changes

@jan--f jan--f Awaiting requested review from jan--f

@jecluis jecluis Awaiting requested review from jecluis

@l-mb l-mb Awaiting requested review from l-mb

@theanalyst theanalyst Awaiting requested review from theanalyst

@holgis holgis Awaiting requested review from holgis

@rjfd rjfd Awaiting requested review from rjfd

@ddiss ddiss Awaiting requested review from ddiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smithfarm @tserong @tchaikov @xiexingguo