Fix broken AutoYaST

[thehejik]

After merging of #197 I found few problems with the AutoYaST profile which needs to be addressed.

I will be extending following list.

Important

• Doesn't work due bsc#1136861 chrony not configured: ref. doc, or use following block from cloned system

  <ntp-client>
    <ntp_policy>auto</ntp_policy>
    <ntp_servers config:type="list">
      <ntp_server>
        <address>pool.ntp.org</address>
        <iburst config:type="boolean">true</iburst>
        <offline config:type="boolean">false</offline>
      </ntp_server>
    </ntp_servers>
    <ntp_sync>systemd</ntp_sync>
  </ntp-client>

• This block for enabling recommended packages fixes all the issue with following missing packages:

<software>
...
  <install_recommended config:type="boolean">true</install_recommended>
...
</software>

• sudo not installed
• chrony not installed
• glibc-locale not installed -> after login as sles user -bash: warning: setlocale: .*: No such file or directory
• SUSEConnect not installed (mainly needed for de-registration)
• ca-certificates+ deps not installed (hence unable to install anything over zypper)
• grub2-snapper-plugin not installed - missing snapper support in grub2
• snapper-zypp-plugin not installed - snapper doesn't create snapshots when installing|updating packages

Minor

• unify value placeholders - either use <!-- replace this comment with a public ssh key --> or [email] | [sles-reg-code] | [caasp-reg-code]method
• [sles-reg-code] shouldn't be needed - try to use [caasp-reg-code] directly instead
• we should distinguish between legacy/BIOS and EFI based machines (2 profiles?) - for eg. we do not need esp partition on BIOS machine

[jordimassaguerpla]

@thehejik Can you create a PR with the fixes? So @Klaven can review it?

[thehejik]

I'm on it but ntp configuration over autoyast is not working, I filed a SLE15-SP1 bug for that https://bugzilla.suse.com/show_bug.cgi?id=1136861

[Klaven]

@thehejik some of those things are installed via the patterns like sudo. Also some seem not needed unless you have a btrfs filesystem like snapper. I think this warrants a larger conversation as we are starting to do some things that are very specific, like BIOS and EFI. How many versions will we support in the end?

[Klaven]

also. install recommended is true by default. no need to set it to true as that is the default behavior.

[Klaven]

@thehejik also maybe you wrote this before the yast file was merged because at one point it had install_recommended=false. this was removed for the final version. Please look at it how it was merged.

[jordimassaguerpla]

@thehejik and @Klaven : IIUC, all is already fixed in the latest version except for the NTP and the UEFI vs legacy BIOS.

@Klaven agreed on updating the documentation regarding UEFI vs legacy BIOS.

@thehejik let us know when you have more info on the NTP

Sounds like a plan ;)

Let me know if I missed anything.

[thehejik]

@Klaven please comment in the PR directly #283

[thehejik]

@Klaven I successfully validated on KVM with EFI fw that the system installed by using autoyast from #283 (improved version with ntp) is fully EFI compatible - even with SecureBoot enabled.

$ mokutil --sb-state
SecureBoot enabled

[thehejik]

The PR was merged, closing