V2: Fixes and improvements to dashboard integration #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2-master #268 +/- ##
============================================
Coverage ? 53.64%
============================================
Files ? 918
Lines ? 25308
Branches ? 4350
============================================
Hits ? 13576
Misses ? 11732
Partials ? 0 |
richard-cox
requested changes
Jan 22, 2020
There was a problem hiding this comment.
- After installing dashboard can immediately go to try to view it... whilst it's still coming up
- Discovered this issue when trying to use Kind - Unable to view kube dashboard in Kind #281
| <div *ngIf="kubeDashboardStatus$ | async as status"> | ||
| <div class="kubedash__ready" *ngIf="status.service && status.serviceAccount"> | ||
| <app-boolean-indicator [showText]="false" [isTrue]="true" type="yes-no"></app-boolean-indicator> | ||
| <div>Kubernetes Dashboard is installed and a Service Account exists - you can access the dashboard using the 'View Dashboard' button on the Summary view for this cluster</div> |
There was a problem hiding this comment.
Would be nice to offer a link straight there
| ) { | ||
| this.kubeDashboardStatus$ = kubeEndpointService.kubeDashboardStatus$; | ||
| // Clear the updatind status when we get back new dashboard status | ||
| this.kubeDashboardStatus$.pipe(distinctUntilChanged()).subscribe(status => { |
There was a problem hiding this comment.
Subscribe without ubsub/first/etc
| } | ||
|
|
||
| private makeRequest(method: string, op: string, busyMsg: string, okMsg: string, errorMsg: string, | ||
| busy: BehaviorSubject<boolean>, readyFilter: ReadyFilter, msgUpdater: MessageUpdater) { |
| @@ -30,4 +30,32 @@ | |||
| &__button { | |||
| margin-left: 4px; | |||
| } | |||
|
|
|||
| &__dashboard-version { | |||
| display: flex; | |||
There was a problem hiding this comment.
Needs a align-items: baseline;
| <mat-card-title>Service Account</mat-card-title> | ||
| <div class="kubedash__card-icon"> | ||
| <app-boolean-indicator *ngIf="status.serviceAccount" [showText]="false" [isTrue]="true" type="yes-no"></app-boolean-indicator> | ||
| <mat-icon *ngIf="!status.serviceAccount">warning</mat-icon> |
There was a problem hiding this comment.
Should the warning icon for both dashboard and service account be red?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
Fixes #270
Fixes #269