Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suse Customizations #3

Merged
merged 15 commits into from
Jun 14, 2018
Merged

Suse Customizations #3

merged 15 commits into from
Jun 14, 2018

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented May 11, 2018

No description provided.

@nwmac nwmac self-assigned this May 11, 2018
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, would also like to review again once customization + eula changes go into upstream.
Also I couldn't see a change in favicon, think these can cache in odd ways though.

</form>
</div>
<div class="suse-login__loading">
<mat-progress-bar mode="query"></mat-progress-bar>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bar looked super long when the window was full screen

@richard-cox richard-cox merged commit 3f76894 into v2-master Jun 14, 2018
@richard-cox richard-cox deleted the suse branch June 14, 2018 16:21
richard-cox pushed a commit that referenced this pull request Oct 31, 2018
richard-cox added a commit that referenced this pull request Apr 23, 2019
richard-cox added a commit that referenced this pull request Apr 26, 2019
* Fix endpoint table --> card error

* Fix tidy up bug

* Add frontend endpoint sub types, wire up to k8s types
- Note - Missing k8s images pending review

* Update icon font

* Fix lint issue

* Update icons

* Fixed lint error, tweaked naming and access

* Allow endpoint types to reference common core endpoint auth types
- stops references of package code in common code
- prep for moving metrics into own package (just need to register metricType obj via decorators)

* Add images for k8s

* Kube dashboard

* Post merge fixes

* Updates

* Editor config change

* Applciation sub nav and sub nav changes

* Fix backend build script

* Fix helm module

* Add favorite to kube endpoint

* Fix endpoint card favorite star

* Remove unneeded favorite config

* Add API to determine if kube dashboard is installed

* Fix compilation issues

* Fix for endpoint favorite card when endpoint type is not known

* Add support for icon mode and a few tidy ups

* Add base kubernetes summary view

* WIP Kube summary charts

* Fix after merge

* Various fixes and tweaks

* Added simple usage chart and pod usage

* Add status graphs

* Little bit of tidy up on kube summary page

* Fix unit tests

* Tidy up kube summary

* Fix code climate issues

* Fix lint issue

* Fix merge issues

* Fix multiple app stats requests on org & space summary pages
- Recent changes to obs chains make them more emitty
- Ensure when we watch apps collection changes that we only fire stats off once

* Fix endpoint card details

* Update GKE given subtype changes

* Add smoother tile layout breakpoints
(once nav side bar changes come in there should be no cut off tile)

* Latest updates

* Add tab labels and icons

* Fix delete button missing and missing icon

* PR Fixes

* Remove warning on startup

* Changes following review

* Fixes and updates

* Fix compilation errors

* Temp fix for tables with cells that use `white-space: nowrap;` and have a loooong words

* Merge fixes

* chip pills are now not bold

* Endpoint status updates

* Disable connect of endpoint types that don't support it

* Sidenav icon

* Add helm status to endpoint lists
- Note - we may want to find another pluggable way of showing custom status text/icons

* Move view namespace in dashboard link to own column, only show if we have the dashboard

* Add loading indicator to k8s summary page to avoid graph flicker

* Split out yaml overrides into second step in install helm chart
- moved step1 into core step as there's not a lot of code
- could also split out name/namespace

* Update all metrics icons to `equalizer`

* Release status & ensure all GetAllEndpoints actions result in a GetSystemSuccess
- use same endpoint status on helm/releases as endpoint list
- we were using the GetAllEndpoints action when working with lists of endpoints..
however this actually did nothing. Now we fire off a GetSystemSuccess whenever
we dispatch GetAllEndpoints

* Remove pod image & tag columns, add `Ready Containers` using `containerStatuses`

* Various updates

* Fix endpoint notification. Tidy up logging

* Add helm versions list to helm config tab

* Also show 'not installed' in helm config versions table

* Fix release resource parsing

* Add pods page & list to helm release page

* Add majority of helm release services page & list
Only thing missing should be the populate of fields in the card, the data is available though just a bit of wiring needed

* susecon script

* Tidy up kube summary page

* Tweaks/Fixes to Helm Release Services

* Tidy up release loading indicators

* Ensure all padding is consistent with dashboard component

* Add services view to kubernetes namespace page
- to do so made base kube services list config and data source classes
- Tweaked kuberetes 'application' name to be inline with labels on how to get there

* Minor improvements regarding kube/helm row uniqueness. Handle helm errors better

* Show helm release service cards quicker

* Only show install button if we have connected k8s & only show connected k8s in install stepper

* Improve helm install yaml overrides text box
- onEnterOverrides unglyness needed due to..
  - size of textbox not autosizing properly
  - visuals of textbox without focus not so nice

* fetchHelmReleaseFromKubernetes --> fetchHelmReleaseServiceFromKubernetes

* Update kube service info when refreshing helm release service list

* Add service link in helm release services list
- will not show as link in other services lists

* Fix sub header title with url param

* Fix no-margin style name change

* Status updates

* Add base step to application creation.

* CC Fixes

* E2e fixes

* Unit test fixes

* Unit test fix

* Unit test fix

* Change cf favorite deploy menu item to create

* Fix home page margins

* Fix kubeService$ error on start up
- works fine, just the compiler being strict

* Add wait for release status to release summary loading indicator
- also unsub from pod data chain

* Fix deleting indicator on helm release page

* Removed debug console.log

* Tidy up helm release summary tab

* Make the kube summary layout reusable and apply to helm release summary

* Improve helm views incluing release and chart summary

* Missed file updates

* Added theme for entity title summary component

* Tighten up the side nav and revert hover change

* Added icon mode to new nav

* Fix mobile nav closing

* WIP

* Impove sidenav auto hiding

* WIP

* Fix unit tests

* Fix auth type select width

* Fix side nav on firefox

* Improve sidenav styling

* Overflow fix for nav top section

* Fix e2e tests, add one more for connect in stepper

* Small tidies/fixes

* helm install reduxing

* Remove HelmReleaseLinkComponent and use cellDefinition link config

* Remove unused HelmRepositoryCountComponent

* Improve typing

* fix imports

* Use common page size with defaultHelmKubeListPageSize

* small tidy ups

* Changes following review

* Small fixes, cater for endpoints that don't require connecting when showing 'no connected' snackbard

* Ensure health check respects doesNotSupportConnect

* more minor tidy ups

* Use app-no-content-message in release notes & values pages

* Fix and use common `unique` function for helm entities & data sources

* minor tidyups

* More fixes
- ensure all helm & kube entity & row unique functions are correct
- update some lists to use valuePath instead of getValue
- typo fixes
- note on dashboard & margin bug
- comment out some todos

* Improve kube typing and use common getKubeAPIResourceGuid

* Re-add shared connection icon to endpoint name
- TODO: add to endpoint card

* Show shared connection notification in endpoint card

* Fix endpoint checking label

* Show cancel/close button on connect endpoint dialog
- if the cf is dodgy and not responding the user should be able to exit the modal

* Fix lint errors

* Fix test compile

* Fix unit tests - Round 1

* Avoid close-->cancel blip on successful connection

* Fix unit tests - Round 2

* Fix unit tests - Round 3

* Fix unit tests - Round 4

* Removed sanitise todo, which happens in [innerHTML]

* Bump go version to 1.12 in travis tests

* Imporve endpoint connect step messaging

* Minor text change to connect endpoint step

* Add plugin info to the info call

* Remove reuse component override on monocular page

* Fix no margin class

* Ensure we don't try to fetch sub nav items too many times

* Remove console log

* User Invite tweaks and helm support

* Fix side nav help

* Fix sidenav help overflow

* Address/update todos

* Address review comments

* Disable demo menu action if plugin is disabled

* Disable helm (see #150)

* Remove unused uiFullView

* Disable kube dashboard functionality via plugin config setting
- plugin config - `kubeDashboardEnabled`
- ensure we don't check to see if dashboard installed in kube if dashboard functionality is disabled
- fix kube service ports (can be used in kube namespace servies list even without helm module)

* Fix lint issues

* Fix finnish as cancel & e2e tests

* Fix metrics e2e test

* Minor fixes

* e2e fixes - Changes to reflect tabs to side and new sub header with action items

* Fix locator

* More specific selector

* Fix merge issues

* Add disabled state to file-input

* Merge fixes - NOTE - help slide out does not block content underneath

* Fix unit test

* remove fdescribe

* Fix e2e tests

* Fix kube summary icon bleed & unit tests

* Fixes after merge

* Fixes after merge

* Fix new unit test failure #1

* Fix new unit test failure #2

* Fix new unit test failure #3

* Fix new unit test failure #4

* Fix failing backend tests

* Update all go references to 12.4

* Changes following merge

* Changes after merge

* Remove custom-src

* Remove kube/helm from backend & docs

* Remove backend downstream deps

* cc fixes

* Changes after merge
nwmac pushed a commit that referenced this pull request Apr 29, 2019
richard-cox added a commit that referenced this pull request Jul 24, 2020
* Improve recent and favourites display (cloudfoundry#4421)

* Improve recent and favourites display

* Remove debug logging

* Remove debug logging/subscription leak

* Unit test fix

* Tweaks following review

* Changes following review
- favourite & recent icon changes

Co-authored-by: Richard Cox <richard.cox@suse.com>

* Add line-height to favourite and recent entity labels (cloudfoundry#4438)

- missed out from another PR following review

* Autoscaler e2e tests: Give better failure error when the test can't find the scaling row (cloudfoundry#4424)

* Improve autoscaler e2e tests

* Remove duplicate fail statement

* Helm Chart: Remove encryption key volume (cloudfoundry#4355)

* Remove encryption key volume

* Remove encrpytion key volume migration from config-init job

* Improve the logout experience (cloudfoundry#4439)

* Add support for including breaking changes in the changelog

* Improve the logout experience

* Fix unit tests

* Add request for version info to github issues template (cloudfoundry#4443)

* Merge downstream (cloudfoundry#4441)

* Merge src/frontend from downstream

* Merge src/jetstream from jetstream

* Remove examples/custom-src

* Merge deploy from downstream
Does not include changes to
- deploy/all-in-one/*
- deploy/aio-entrypoint.sh
- deploy/Dockerfile.all-in-one

* Merge build from downstream

* Add missing merge items from deploy

* Updates to package-lock

* Remove fdescribe

* Fix e2e core tests

* Remove favicon from packages/core/src

* Changes following review

* Show all favorites for an endpoint favorite if there is only one (cloudfoundry#4440)

* Show all favorites for the endpoint favorite if there is only one

* Missing changes

* Merge downstream - JSON Viewer with dark mode & Header Fixes (cloudfoundry#4444)

* Fix json-viewer dark mode

* Fix profile page and side nav top position following header diet
- Fix side nav top position
- Update fix for profile page to also work in non-desktop mode

* Fix issues with tests not running if build upload fails (cloudfoundry#4453)

* Fix issues with tests not running if build upload fails

* Fix script

* One more fix for script

* Fix white space at start of file

* Improve autoscaler e2e logging (cloudfoundry#4456)

* Improve autoscaler e2e logging
- it looks like the AS returns scaling events 1-2 mins after they occur, which is too late for the test
- add additional logging to print out event table data in case of alternative events being raised
- fix logging if wait for events times out
- add hint in later test that depends on AS scaling event

* Ensure only the schedule rule results in scaling events

* Fix check-e2e-pr.sh for pr's from other repos (cloudfoundry#4459)

- switch from TRAVIS_PULL_REQUEST_SLUG to TRAVIS_REPO_SLUG

* Convert Client Secret Input Fields to `password` (cloudfoundry#4455)

* Insecure tlsv10 and tlsv11 ciphers in Stratos UI, bsc#1173295 (#411) (cloudfoundry#4460)

Co-authored-by: Michal Jura <mjura@users.noreply.github.com>

* [Security] Bump codecov from 3.7.0 to 3.7.1 (cloudfoundry#4457)

Bumps [codecov](https://github.com/codecov/codecov-node) from 3.7.0 to 3.7.1. **This update includes a security fix.**
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Commits](codecov/codecov-node@v3.7.0...v3.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* Bump lodash from 4.17.15 to 4.17.19 (cloudfoundry#4452)

Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](lodash/lodash@4.17.15...4.17.19)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Convert scripts to nodejs so they work on Windows (cloudfoundry#4462)

* Convert scripts to js so they work on Windows

* Improve initial developer experience

* Fix scss compile on windows

* Fix windows build

* Use fs not fs-extra where possible (can work without npm install)

* Remove gulp

* Cleaner fixes for Windows

* Reset

* Fix whitespace

* Address PR feedback

Co-authored-by: Neil MacDougall <nmacdougall@suse.com>

* Shorten file paths containing `cloudfoundry`/`cloud-foundry` (cloudfoundry#4466)

* Fix 'too long' file paths

* Fix build issues

* Convert scripts to js so they work on Windows

* Fix scss compile on windows

* Improve initial developer experience

* Fix scss compile on windows

* Fix windows build

* Use fs not fs-extra where possible (can work without npm install)

* Remove gulp

* Cleaner fixes for Windows

* Reset

* Fix whitespace

* Fix merge

Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>

* Fix log out page when there's a custom log in page (cloudfoundry#4467)

* Add service broker space scope information to service wall list (cloudfoundry#4463)

* Add service broker space scope information to service wall list

* Split out `Space Scope` into it's own `Scope` row/column

* Add service broker scope to service instance list (card and table) & app binding list (card)

* Fix e2e test

* Fix services table, cater for brokers that return 403

* Changes following review
- Show space scope link in app service list (quick access)
- Harmonize names (Service, broker, scope, etc)
- Fix space scope link in services wall

* Remove recents and favorites when entities are deleted (cloudfoundry#4431)

* Improve recent and favourites display

* Remove debug logging

* Remove debug logging/subscription leak

* Unit test fix

* Remove recents and favorites when entities are deleted

* Fix merge issues

* Fix merge issue

* Tidy up and improve following PR feedback

* Remove out of date comment

* Fixed problem where clear was not working

* Check favorite exists before deleting

* Version bump and change log (cloudfoundry#4469)

* Version bump and change log

* Update changelog

Co-authored-by: Neil MacDougall <nwmac@users.noreply.github.com>
Co-authored-by: Michal Jura <mjura@users.noreply.github.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Neil MacDougall <nmacdougall@suse.com>
Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants