Add containers table in pods list pod row drop down #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
richard-cox
commented
Mar 6, 2020
richard-cox
commented
- Remove concept of fixed height table rows
- Added concept of min height table rows
- Reduced default height of rows
- Added new table cell 'icon' component
- Add ability to show a custom component on click of a table's row
- Used new feature to add list of containers to pod view
- Remove concept of fixed height rows - Added concept of min height rows - Reduced default height of rows - Added new table cell 'icon' component - Used new feature to add list of containers to pod view
|
|
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
- Coverage 58.94% 58.91% -0.03%
==========================================
Files 1030 1034 +4
Lines 32180 32406 +226
Branches 4408 4452 +44
==========================================
+ Hits 18968 19092 +124
- Misses 13212 13314 +102 |
richard-cox
commented
Mar 30, 2020
...ared/components/list/list-table/app-table-cell-default/app-table-cell-default.component.html
Show resolved
Hide resolved
...shared/components/list/list-table/table-cell-side-panel/table-cell-side-panel.component.html
Show resolved
Hide resolved
...end/packages/core/src/shared/components/list/list-table/table-cell/table-cell.component.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.