Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a Kubernetes Terminal #384

Merged
merged 55 commits into from
Jun 26, 2020
Merged

Add support for a Kubernetes Terminal #384

merged 55 commits into from
Jun 26, 2020

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Jun 4, 2020

No description provided.

nwmac and others added 30 commits June 23, 2019 17:30
Signed-off-by: Ben Berry <ben.berry@gsa.gov>
Signed-off-by: Ben Berry <ben.berry@gsa.gov>
…-notes

3.2.1 Version bump and release notes
@nwmac nwmac added the ready for review Ready for review label Jun 4, 2020
@nwmac nwmac self-assigned this Jun 4, 2020
@nwmac nwmac added the blocked label Jun 4, 2020
@nwmac nwmac removed the blocked label Jun 23, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2020

Codecov Report

Merging #384 into master will decrease coverage by 0.31%.
The diff coverage is 42.18%.

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
- Coverage   59.61%   59.29%   -0.32%     
==========================================
  Files        1057     1070      +13     
  Lines       33286    33847     +561     
  Branches     4673     4764      +91     
==========================================
+ Hits        19844    20071     +227     
- Misses      13442    13776     +334     

@nwmac nwmac requested a review from richard-cox June 24, 2020 13:00
Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments

Copy link
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once passed gates

@richard-cox richard-cox merged commit 5c95d1c into master Jun 26, 2020
@richard-cox richard-cox deleted the kube-terminal branch June 26, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants