Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workload: Add warning if manifest parse contains errors #391

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Workload: Add warning if manifest parse contains errors #391

merged 4 commits into from
Jun 18, 2020

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox added the ready for review Ready for review label Jun 16, 2020
richard-cox
richard-cox commented Jun 17, 2020
View reviewed changes
Copy link
Member Author

@richard-cox richard-cox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

...custom/kubernetes/workloads/release/helm-release-tab-base/helm-release-tab-base.component.ts Outdated Show resolved Hide resolved
...custom/kubernetes/workloads/release/helm-release-tab-base/helm-release-tab-base.component.ts Outdated Show resolved Hide resolved
custom-src/frontend/app/custom/kubernetes/workloads/release/tabs/helm-release-helper.service.ts Outdated Show resolved Hide resolved
custom-src/frontend/app/custom/kubernetes/workloads/store/workload-action-builders.ts Outdated Show resolved Hide resolved
custom-src/frontend/app/custom/kubernetes/workloads/store/workloads.actions.ts Outdated Show resolved Hide resolved
src/jetstream/plugins/kubernetes/get_release.go Show resolved Hide resolved
nwmac
nwmac approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox added the needs attention Needs attention label Jun 17, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #391 into master will increase coverage by 0.15%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   59.19%   59.35%   +0.15%     
==========================================
  Files        1052     1052              
  Lines       33119    33124       +5     
  Branches     4643     4645       +2     
==========================================
+ Hits        19606    19661      +55     
+ Misses      13513    13463      -50

@richard-cox richard-cox removed the needs attention Needs attention label Jun 17, 2020
@richard-cox richard-cox merged commit 790a37f into master Jun 18, 2020
@richard-cox richard-cox deleted the helm-manifest-parse-warning branch June 18, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload: Add warning if manifest parses with errors
3 participants
@richard-cox @codecov-commenter @nwmac