Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream #406

Merged
merged 206 commits into from
Jul 9, 2020
Merged

Merge upstream #406

merged 206 commits into from
Jul 9, 2020

Conversation

richard-cox
Copy link
Member

No description provided.

richard-cox and others added 22 commits June 24, 2020 15:23
… Entities (cloudfoundry#4387)

* WIP

* WIP

* WIP

* Endpoint changes

* Fix failure handling during connect on stepper

* Fix favourites

* Removed some TODOs

* Fixes & todos

* Unit test fixes

* Fixes following merge

* Fix cf unit tests

* Changes following review
Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
…ements

Theming improvements for page header
* Remove action entityLocation (not used)

* Fix restage
- fixes cloudfoundry#4392

* Remove RequestEntityLocation
* Update icons

* Update docker icon and optimize other pngs

* Improve resolution of container icon

* Update e2e test for new icons
…, improve code splitting (cloudfoundry#4412)

* Move out cf themese from _all-theme & remove custom cf table sort/filter field widths

* Move cf routes out of app.routing & move out cf route modules from cf package module (fixes code splitting)

* Fix autoscaler e2e test

* Split out CF modules and router imports into custom module

* Create cf-autoscaler package & routing modules
- note - CfAutoscalerModule is imported in CfAutoscalerPackageModule
- note - AutoscalerModule should be brought back into CfAutoscalerModule (stepper is lazy loaded.. but content missing elsewhere)

* Fix autoscaler e2e test #2

* Fix app autoscaler tab widgets, import using package name

* Move CfAutoscalerModule (app AS tab) out of always loaded AS package into lazy loaded app module

* Add comments, fix e2e test following app-running-instance change

* Allow routes to be applied to stratos navigation root without appearing in side nav

* Fix app-card-app-usage on app AS tab
- only seen when policy does not contain metrics restrictions
- fixes by bringing in CloudFoundrySharedModule again to CfAutoscalerModule
- means an also use app-running-instances again
- i've checked the chunks & sizes, they're similar as before

* Move CloudFoundrySharedModule out of CloudFoundryPackageModule

* Add comments

* Bring back in smaller search/sort input fields in main lists

* Bring back lost styling
* Use smaller page header on desktop browsers

* Change tooltip appear time
* Allow ng build to be un from any subfolder

* Add support for packages in orgs
@richard-cox richard-cox added the ready for review Ready for review label Jul 7, 2020
@richard-cox richard-cox self-assigned this Jul 7, 2020
@richard-cox richard-cox mentioned this pull request Jul 7, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #406 into master will decrease coverage by 0.28%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   56.48%   56.20%   -0.29%     
==========================================
  Files         886      891       +5     
  Lines       28963    29209     +246     
  Branches     4213     4232      +19     
==========================================
+ Hits        16359    16416      +57     
- Misses      12604    12793     +189     

Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 14479c5 into master Jul 9, 2020
@nwmac nwmac deleted the merge-upstream branch July 9, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants