Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidepanel update #540

Closed
wants to merge 16 commits into from
Closed

Sidepanel update #540

wants to merge 16 commits into from

Conversation

nwmac
Copy link
Member

@nwmac nwmac commented Nov 12, 2020

No description provided.

Vítor Avelino and others added 16 commits December 10, 2019 06:41
Signed-off-by: Vítor Avelino <vavelino@suse.com>
- Issue 1 (slightly unrelated)
  - app service getspace action used space entity without an org
- Issue 2
  - app entity validation found it was missing the space
  - validation process fetched space with custom action
  - custom action did not contain schema key to use space with org schema
  - org was not stored correctly in store (contained in space rather than seperatly)
- Still to do
  - Fix for issue 2 would need to be expanded to ALL schema's with inline entities
  - These new schemas would need to be added to their entities
  - All usages would have to provide the overriding schemaKey
This reverts commit 0a16203284cc0b42d172972047f5d08cddfecc99.
    - Issue 1 (slightly unrelated)
      - app service getspace action used space schema without an org
    - Issue 2
      - app entity validation found it was missing the space
      - validation process fetched space with custom action
      - custom action did not contain schema key linked to space schema with org
      - this lead to org being not stored correctly in store (contained in space rather than seperatly)
      - Simple fix (see 0a16203284c for harder)
         - When normalizing prioritise the action's schema over attempting
           to fetch via entity catalogue + schemaKey
           (avoids A LOT of plumbing)
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
Signed-off-by: Vítor Avelino <vavelino@suse.com>
@nwmac nwmac closed this Nov 12, 2020
@nwmac nwmac deleted the sidepanel-update branch November 12, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants