Add support to CSS color name transparent
#583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
<color>element, current we support all the color name listed in SVG 1.1- 147 color names.However, the
<color>element, now defined in CSS spec here supportstransparentkeyword.The CSS spec for color is huge and supports many complicated color like
hsl(),hsla(). We don't have enough time to support them one by one. But I think thin simple one is easy to implement.After this fix, we can now correctlly render the demo SVG from MDN for showing
radialGradient-fxvalue. The full radialGradient implementation is available soon, this one is much simpler so I create a separate PR.