Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SGF Parsing for backslashes in comments #69

Closed
yewang opened this issue Apr 21, 2016 · 1 comment
Closed

SGF Parsing for backslashes in comments #69

yewang opened this issue Apr 21, 2016 · 1 comment
Labels
bug sgf

Comments

@yewang
Copy link

yewang commented Apr 21, 2016

It seems that the SGF parser may fail on certain edge cases:

(;C[\];B[aa];W[bb])
Two nodes: comment ];B[aa in root node, white move in second node

(;C[\\];B[aa];W[bb])
Three nodes: comment \ in root node, black move in second node, white move in third node

(;C[\\\];B[aa];W[bb])
Two nodes: comment \];B[aa in root node, white move in second node

(;C[\\\\];B[aa];W[bb])
Three nodes: comment \\ in root node, black move in second node, white move in third node
@yishn
Copy link
Member

yishn commented Apr 21, 2016

Thanks! Seems to be a problem with the tokenizer...

@yishn yishn closed this as completed Apr 21, 2016
yishn added a commit that referenced this issue Apr 21, 2016
@yishn
Fix sgf.unescapeString()
0c6d429 
Close #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug sgf
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yewang @yishn