Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine synchronization #316

Merged
merged 24 commits into from Dec 30, 2017
Merged

Engine synchronization #316

merged 24 commits into from Dec 30, 2017

Conversation

yishn
Copy link
Member

@yishn yishn commented Dec 29, 2017 •
edited

Currently, to update the attached engine to current board arrangement, Sabaki will recreate the board by placing stones from upper left to lower right. This causes problems in some engines which use neural networks (see #294).

This pull request introduces a new module enginesyncer which will be responsible for engine synchronization. It will try to update the board arrangement in the following order:

  1. Try to update engine board with one move
  2. Try to recreate board by replaying moves and additional stones in order of the game tree
  3. If all above fails, try to recreate board by placing stones from upper left to lower right

@yishn
Board.diff() returns null if size does not match
ebc759f
@yishn
Controller.sendCommand() returns promise
4901944
@yishn
Add gtp.syncBoard() with incremental board update sync
ebab957
@yishn
Implement replay strategy of engine sync
a416d50
@yishn
Implement rearrangement strategy of engine sync
70f5254
@yishn
Update komi
4da356c
@yishn
Rename module
81f1073
@yishn
Deprecate sabaki.sendGTPCommand()
79654d6
@yishn
Don't dump engine info onto controller
1ae0e2d
@yishn
Controller emits 'command-sent' event
41a228c
@yishn
Revert "Deprecate sabaki.sendGTPCommand()"
132ef64 
This reverts commit 79654d6.
@yishn
Handle command-sent event of engine controllers
72d7cb0
@yishn
Remove sabaki.sendGTPCommand()
215963f
@yishn
Replace sabaki.engineBoards with engineStates
30cdfc7
@yishn
enginesyncer.sync() returns new engine state
3b4959b
@yishn
Controller.sendCommand() returns response object as Promise
f8b0aee
@yishn
Remove callback from Controller.sendCommand()
82f1ecd
@yishn
Fix Controller
e7c9f2c
@yishn
Use enginesyncer module for syncEngines
cd528eb
@yishn
Don't sync engines on attaching
1cfbd21
@yishn
Faster engine sync
ddf9db2
@yishn yishn added the engines label Dec 29, 2017
@yishn yishn added this to the v0.32.0 milestone Dec 29, 2017
@yishn yishn merged commit 323cc4c into master Dec 30, 2017
@yishn yishn deleted the engine-sync branch December 30, 2017 11:28
@killerducky
Copy link

Oh I was just starting to look into this, but it seems you've already got a solution, great work!

@killerducky killerducky mentioned this pull request Dec 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
engines
Milestone
v0.32.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yishn @killerducky