Issue 807 #825
Merged
Issue 807 #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Yunzi theme.
fix issue SabakiHQ#807 element offsetWidth and offsetHeight are rounded to integers, which was causing off by one errors when further rounded to calculate top and left values. This fix uses the raw floating point width and height from getBoundingClientRect(). The jittering described in the issue is easily reproduced by resizing the developer window to squash the goban, certain sizes are problematic. I've not been able to reproduce the issue with this fix in place.
|
Not sure how to loose those spurious extra commits in the history, I thought merging your repo master to my fork master then merging my master onto my branch would do it, but it just made it worse 😁 There's only one commit. |
|
No worries, I can squash them all together when merging :) Just going to attempt to reproduce this fix locally - assuming it works, I'm really really appreciative you sleuthed this down! |
|
I can't take full credit, I showed the problem to some friends at work and one pointed me to the relevant code, his suggested fix (replace round with floor) wasn't quite right but it narrowed down my search considerably. |
apetresc
approved these changes
Oct 9, 2021
|
Fully confirmed this fix works. |
|
Cool |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #807
Floating point rounding error because offsetHeight and offsetWidth are already rounded to integers.