Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize Table #141

Closed
lars-reimann opened this issue Apr 1, 2023 · 1 comment · Fixed by #310
Closed

Normalize Table #141

lars-reimann opened this issue Apr 1, 2023 · 1 comment · Fixed by #310
Assignees
@zzril @sibre28
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Apr 1, 2023 •
edited

Is your feature request related to a problem?

Normalization mean to shift and squeeze the data into the interval [0, 1]. More generally, we can do that for any interval [minimum, maximum].

Desired solution

  • Add a class RangeScaler in safeds.data.tabular.transformation that wraps the MinMaxScaler of scikit-learn
  • Make it a subclass of InvertibleTableTransformer
  • Add two parameters to the __init__ method to set the minimum (float, default 0.0) and maximum (float, default 1.0).
  • Raise a value error if minimum >= maximum.
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Apr 1, 2023
@lars-reimann lars-reimann mentioned this issue Apr 4, 2023
Closed
@zzril zzril linked a pull request May 19, 2023 that will close this issue
feat: Add RangeScaler transformer #310
Merged
@zzril zzril mentioned this issue May 19, 2023
Merged
robmeth pushed a commit that referenced this issue May 19, 2023
@zzril @sibre28 @megalinter-bot
feat: Add RangeScaler transformer (#310)
f687840 
Closes #141.

### Summary of Changes

* Added new class `RangeScaler` in `tabular/transformation`.
* Added tests.

Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>

---------

Co-authored-by: Simon <s6snbreu@uni-bonn.de>
Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Jun 1, 2023
@semantic-release-bot
chore(release): 0.13.0 [skip ci]
9a332b2 
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzril zzril

@sibre28 sibre28

Labels
enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add RangeScaler transformer Safe-DS/Library
3 participants
@lars-reimann @zzril @sibre28