Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns that are added/changed/removed by a TableTransformer #190

Closed
lars-reimann opened this issue Apr 14, 2023 · 3 comments · Fixed by #304
Closed

Columns that are added/changed/removed by a TableTransformer #190

lars-reimann opened this issue Apr 14, 2023 · 3 comments · Fixed by #304
Assignees
@zzril @sibre28
Labels
documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Apr 14, 2023 •
edited by alex-senger

Is your feature request related to a problem?

It would be useful to know which columns get added, changed, or removed by a TableTransformer.

Desired solution

The TableTransformer abstract base class should get three new abstract methods:

  • get_names_of_added_columns
  • get_names_of_changed_columns
  • get_names_of_removed_columns

Each of them should return a list of strings in correct order. All subclasses of TableTransformer must implement these methods. The docstrings of the subclasses should also describe how columns are affected by the transformer.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Apr 14, 2023
@lars-reimann lars-reimann changed the title Get columns that get added/changed/removed by a TableTransformer Get columns that are added/changed/removed by a TableTransformer Apr 14, 2023
@lars-reimann lars-reimann changed the title Get columns that are added/changed/removed by a TableTransformer Columns that are added/changed/removed by a TableTransformer Apr 14, 2023
@lars-reimann lars-reimann mentioned this issue Apr 14, 2023
Closed
@lars-reimann lars-reimann added the documentation 📖 Improvements or additions to documentation label Apr 14, 2023
@lars-reimann lars-reimann mentioned this issue Apr 17, 2023
Merged
@lars-reimann lars-reimann mentioned this issue May 6, 2023
Closed
@zzril
Copy link
Contributor

zzril commented May 12, 2023

It is unclear which table the methods should refer to.
E.g., should get_names_of_changed_columns, applied on an Imputer instance, return a list of those column names that have been changed in the last table the Imputer has been used to transform? (That would mean we store data that logically belongs to a Table globally in the Transformer class.)
Or should it return all the column names that can in principle be affected, i.e. all names that had been passed to fit?

@zzril zzril added the question Further information is requested label May 12, 2023
@lars-reimann
Copy link
Member Author

Or should it return all the column names that can in principle be affected, i.e. all names that had been passed to fit?

This.

@zzril zzril mentioned this issue May 12, 2023
Merged
@zzril zzril linked a pull request May 12, 2023 that will close this issue
feat: Add methods that tell which columns would be affected by a transformer #304
Merged
@zzril zzril removed the question Further information is requested label May 12, 2023
PhilipGutberlet pushed a commit that referenced this issue May 19, 2023
@zzril @sibre28 @megalinter-bot
feat: Add methods that tell which columns would be affected by a tran…
3933b45 
…sformer (#304)

Closes #190 .

### Summary of Changes

Added abstract methods `get_names_of_added_columns`,
`get_names_of_changed_columns`, `get_names_of_removed_columns` in
`TableTransformer` class.
Added implementations for all transformers.

Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>

---------

Co-authored-by: Simon <s6snbreu@uni-bonn.de>
Co-authored-by: sibre28 <86068340+sibre28@users.noreply.github.com>
Co-authored-by: megalinter-bot <129584137+megalinter-bot@users.noreply.github.com>
lars-reimann pushed a commit that referenced this issue Jun 1, 2023
@semantic-release-bot
chore(release): 0.13.0 [skip ci]
9a332b2 
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzril zzril

@sibre28 sibre28

Labels
documentation 📖 Improvements or additions to documentation enhancement 💡 New feature or request released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add methods that tell which columns would be affected by a transformer Safe-DS/Library
4 participants
@lars-reimann @zzril @sibre28 @alex-senger