Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warnings from Transformer methods added in #304 #323

Closed
zzril opened this issue May 26, 2023 · 1 comment · Fixed by #324
Closed

Remove warnings from Transformer methods added in #304 #323

zzril opened this issue May 26, 2023 · 1 comment · Fixed by #324
Assignees
@zzril @sibre28
Labels
enhancement 💡 New feature or request good first issue Good for newcomers released Included in a release

Comments

@zzril
Copy link
Contributor

zzril commented May 26, 2023

Is your feature request related to a problem?

We decided that the warnings in the Transformer methods added by #304 are unneccessary, so they should be removed.

We're talking about these warnings, e.g. here:

warnings.warn("OneHotEncoder only removes and adds, but does not change any columns.", stacklevel=1)

Desired solution

In all transformers, go through the methods get_names_of_added_columns, get_names_of_changed_columns and get_names_of_removed_columns and remove the warnings.
Update tests accordingly.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@zzril zzril added enhancement 💡 New feature or request good first issue Good for newcomers labels May 26, 2023
@zzril zzril linked a pull request May 26, 2023 that will close this issue
feat: Remove warnings thrown in new Transformer methods #324
Merged
This was referenced May 26, 2023
Merged
Merged
sibre28 added a commit that referenced this issue May 26, 2023
@zzril @sibre28
feat: Remove warnings thrown in new Transformer methods (#324)
ca046c4 
Closes #323.

### Summary of Changes

Removed the warnings from `get_names_of_added_columns`,
`get_names_of_changed_columns` and `get_names_of_removed_columns` in all
transformers.
Updated tests accordingly.

---------

Co-authored-by: Simon <s6snbreu@uni-bonn.de>
lars-reimann pushed a commit that referenced this issue Jun 1, 2023
@semantic-release-bot
chore(release): 0.13.0 [skip ci]
9a332b2 
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member

🎉 This issue has been resolved in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzril zzril

@sibre28 sibre28

Labels
enhancement 💡 New feature or request good first issue Good for newcomers released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Remove warnings thrown in new Transformer methods Safe-DS/Library
3 participants
@lars-reimann @zzril @sibre28