Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RangeScaler transformer #310

Merged
merged 20 commits into from
May 19, 2023
Merged

feat: Add RangeScaler transformer #310

merged 20 commits into from
May 19, 2023

Conversation

zzril
Copy link
Contributor

@zzril zzril commented May 19, 2023

Closes #141.

Summary of Changes

  • Added new class RangeScaler in tabular/transformation.
  • Added tests.

Co-authored-by: sibre28 86068340+sibre28@users.noreply.github.com

@zzril zzril linked an issue May 19, 2023 that may be closed by this pull request
@lars-reimann
Copy link
Member

lars-reimann commented May 19, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 0.82s
✅ PYTHON mypy 3 0 2.46s
✅ PYTHON ruff 3 0 0 0.05s
✅ REPOSITORY git_diff yes no 0.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@zzril zzril changed the title 141 normalize table 141 feat: Add RangeScaler May 19, 2023
@zzril zzril changed the title 141 feat: Add RangeScaler 141 feat: Add RangeScaler transformer May 19, 2023
@zzril zzril changed the title 141 feat: Add RangeScaler transformer feat: Add RangeScaler transformer May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #310 (6d5f699) into main (3933b45) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        44    +1     
  Lines         1836      1896   +60     
=========================================
+ Hits          1836      1896   +60     
Impacted Files Coverage Δ
src/safeds/data/tabular/transformation/__init__.py 100.00% <100.00%> (ø)
...afeds/data/tabular/transformation/_range_scaler.py 100.00% <100.00%> (ø)

@zzril zzril marked this pull request as ready for review May 19, 2023 13:22
@zzril zzril requested a review from a team as a code owner May 19, 2023 13:22
@robmeth robmeth merged commit f687840 into main May 19, 2023
8 checks passed
@robmeth robmeth deleted the 141-normalize-table branch May 19, 2023 14:06
lars-reimann pushed a commit that referenced this pull request Jun 1, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-06-01)

### Features

* add `Choice` class for possible values of hyperparameter ([#325](#325)) ([d511c3e](d511c3e)), closes [#264](#264)
* Add `RangeScaler` transformer ([#310](#310)) ([f687840](f687840)), closes [#141](#141)
* Add methods that tell which columns would be affected by a transformer ([#304](#304)) ([3933b45](3933b45)), closes [#190](#190)
* Getters for hyperparameters of Regression and Classification models ([#306](#306)) ([5c7a662](5c7a662)), closes [#260](#260)
* improve error handling of table ([#308](#308)) ([ef87cc4](ef87cc4)), closes [#147](#147)
* Remove warnings thrown in new `Transformer` methods ([#324](#324)) ([ca046c4](ca046c4)), closes [#323](#323)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalize Table
5 participants