Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up implementation & tests of models with hyperparameters #261

Merged
merged 12 commits into from
May 3, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 3, 2023

Summary of Changes

  • Add leading underscore to the names of all hyperparameters
  • Add some comments to mark sections of a constructor
  • Move all validation code to the front of the constructors
  • Add missing validation of bounds
  • Normalize structure of tests

@lars-reimann
Copy link
Member Author

lars-reimann commented May 3, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 30 0 0 0.95s
✅ PYTHON mypy 30 0 2.3s
✅ PYTHON ruff 30 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #261 (9248a45) into main (ec73260) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   99.23%   99.23%           
=======================================
  Files          44       44           
  Lines        1561     1569    +8     
=======================================
+ Hits         1549     1557    +8     
  Misses         12       12           
Impacted Files Coverage Δ
...feds/ml/classical/classification/_decision_tree.py 100.00% <ø> (ø)
...l/classical/classification/_logistic_regression.py 100.00% <ø> (ø)
...lassical/classification/_support_vector_machine.py 100.00% <ø> (ø)
...c/safeds/ml/classical/regression/_decision_tree.py 100.00% <ø> (ø)
...afeds/ml/classical/regression/_lasso_regression.py 100.00% <ø> (ø)
...feds/ml/classical/regression/_linear_regression.py 100.00% <ø> (ø)
...ml/classical/regression/_support_vector_machine.py 100.00% <ø> (ø)
src/safeds/ml/classical/classification/__init__.py 100.00% <100.00%> (ø)
...c/safeds/ml/classical/classification/_ada_boost.py 100.00% <100.00%> (ø)
.../ml/classical/classification/_gradient_boosting.py 100.00% <100.00%> (ø)
... and 9 more

@lars-reimann lars-reimann marked this pull request as ready for review May 3, 2023 12:35
@lars-reimann lars-reimann requested a review from a team as a code owner May 3, 2023 12:35
@lars-reimann lars-reimann merged commit 426972b into main May 3, 2023
@lars-reimann lars-reimann deleted the model_cleanup branch May 3, 2023 14:30
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants