docs: Highlighting the fact, that certain methods do not work in place #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipGutberlet
changed the title
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1708 1708
=========================================
Hits 1708 1708
|
lars-reimann
requested changes
May 5, 2023
There was a problem hiding this comment.
Such a hint would also be great for Column.rename and Column.transform (the latter gets added in #270).
…o-not-change-an-object-in-place-but-return-a-new-one
lars-reimann
approved these changes
May 6, 2023
lars-reimann
deleted the
189-always-specify-explicitly-that-methods-do-not-change-an-object-in-place-but-return-a-new-one
branch
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189.
Summary of Changes
Highlighting the fact, that fitting methods of Classifier, Regressor, Tabletransformer and certain methods of the _table class do not work in place.