Made TypeScript definitions generic and explicit about undefined #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good, I did literally the same - except I had forgotten about undefined. |
|
Thanks a bunch for this! Will publish a version shortly to update types. |
|
This is up now on v1.4.0, sorry for the delay and thanks again for this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types weren't reaching their potential given the presence of the
anytype, so I added generics to allow for more context when using a Deque. The generic type is defaulted toany, so this change should be entirely backwards compatible. I tried to accurately reflect when a type could beundefinedas well, but that might be worth a look.I didn't do anything with the version number or anything like that, so let me know if you'd like me to handle that.