Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing commerce-sdk-react logout call #1180

Merged
merged 2 commits into from
May 10, 2023
Merged

Fix missing commerce-sdk-react logout call #1180

merged 2 commits into from
May 10, 2023

Conversation

kevinxh
Copy link
Collaborator

@kevinxh kevinxh commented May 9, 2023 •
edited
Loading

Description

This PR adds the missing call to SLAS logoutCustomer endpoint, for security purposes. This endpoint is used to invalidate the access token and refresh tokens.

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Documentation update
  • Breaking change (could cause existing functionality to not work as expected)
  • Other changes (non-breaking changes that does not fit any of the above)

Breaking changes include:

  • Removing a public function or component or prop
  • Adding a required argument to a function
  • Changing the data type of a function parameter or return value
  • Adding a new peer dependency to package.json

Changes

  • add SLAS logoutCustomer call

How to Test-Drive This PR

  • cd packages/template-retail-react-app && npm start
  • log in as a customer
  • open network tab and log out
  • verify a call to the /logout endpoint is made
  • verify the old jwt is now invalid

Checklists

General

  • Changes are covered by test cases
  • CHANGELOG.md updated with a short description of changes (not required for documentation updates)

Accessibility Compliance

You must check off all items in one of the follow two lists:

  • There are no changes to UI

or...

Localization

  • Changes include a UI text update in the Retail React App (which requires translation)

@kevinxh kevinxh requested a review from a team as a code owner May 9, 2023 15:56
vcua-mobify
vcua-mobify approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@vcua-mobify vcua-mobify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me

@kevinxh kevinxh merged commit 65ac429 into v3 May 10, 2023
21 checks passed
@kevinxh kevinxh deleted the commerce-sdk-react-logout branch May 10, 2023 15:50
bfeister added a commit that referenced this pull request May 10, 2023
@bfeister
Merge branch 'v3' into feature/template-extensibility-algo-refactor
3190c1f 
* v3:
  Fix missing commerce-sdk-react logout call (#1180)
bfeister added a commit that referenced this pull request May 10, 2023
@bfeister
Merge branch 'v3' into feature/template-extensibility-algo-refactor
61e32b8 
* v3:
  [v3] Add Convenience Components (#1183)
  Update commerce-sdk-react README (#1176)
  Fix missing commerce-sdk-react logout call (#1180)

# Conflicts:
#	packages/template-retail-react-app/app/components/_app/index.jsx
#	packages/template-retail-react-app/app/pages/product-list/index.jsx
bfeister added a commit that referenced this pull request May 23, 2023
@bfeister
Merge branch 'develop' into feature/template-extensibility
7dafb99 
* develop: (37 commits)
  [Phased Launch] Call Session bridge after login (#1220)
  [v3] Add multi-site suffix to auth token keys (#1208)
  Footer: fix hydration error with the locale dropdown (#1210)
  remove unused peerDependency @chakra-ui/system (#1212)
  @W-12582733: Expose env vars endpoint for E2E smoke tests (#1207)
  Upgrade to React 18 (#1166)
  Remove v3 branch name related actions (#1206)
  add test to reach test coverage threshold
  remove commerce-api folder
  Feature: Extract einstein RefArch-specific values to constant (#1200)
  Bump version number to 2.7.1 and update changelogs (#1197)
  store usid in cookies (#1193)
  make sure static files are copied on dev environment (#1196)
  [WIP] PWA Kit 2.7.1 release (#1181)
  [V2] Internal lib build typescript dev dependency (#1194)
  [V2] Re-generate lock files and fix hook lib tests (#1186)
  [v3] Add Convenience Components (#1183)
  Update commerce-sdk-react README (#1176)
  Add additional properties to ShopperLogin test types (#1185)
  Fix missing commerce-sdk-react logout call (#1180)
  ...

# Conflicts:
#	package-lock.json
#	packages/commerce-sdk-react/CHANGELOG.md
#	packages/commerce-sdk-react/package-lock.json
#	packages/internal-lib-build/package-lock.json
#	packages/pwa-kit-create-app/package-lock.json
#	packages/pwa-kit-dev/package-lock.json
#	packages/pwa-kit-react-sdk/package-lock.json
#	packages/pwa-kit-runtime/package-lock.json
#	packages/template-mrt-reference-app/package-lock.json
#	packages/template-retail-react-app/package-lock.json
#	packages/template-typescript-minimal/package-lock.json
#	packages/test-commerce-sdk-react/package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendvc bendvc bendvc approved these changes

@vcua-mobify vcua-mobify vcua-mobify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinxh @bendvc @vcua-mobify