@W-12582733: Expose env vars endpoint for E2E smoke tests #1207

josebarrios-sfdc · 2023-05-15T17:56:48Z

As we roll out the new customer-defined environment variables, we must update the reference app to include this feature in our E2E smoke tests.

Created an /env-vars endpoint that returns a subset of environment variables set in Lambda

How to Test-Drive This PR

npm build and start the app
Navigate to http://localhost:3000/ and ensure it returns a 200 no customer set variables an empty object
Push this app to a project that has env-vars enabled, or verify that env vars show up in the test site . If using the test project, the following env vars should be returned:

    'customer_defined_array',
    'customer_defined_boolean',
    'customer_defined_float',
    'customer_defined_integer',
    'customer_defined_json',
    'customer_defined_null',
    'customer_defined_string',

packages/template-mrt-reference-app/app/ssr.js

.gitignore

bfeister

PR looks good, might need npm run lint:fix to pass the lint step in CI

packages/template-mrt-reference-app/app/ssr.js

johnboxall

Approved, but please take a moment to read my nits.

…merceCloud/pwa-kit into custom-env-var-smoke-tests

packages/template-mrt-reference-app/app/ssr.test.js

…merceCloud/pwa-kit into custom-env-var-smoke-tests

* develop: (37 commits) [Phased Launch] Call Session bridge after login (#1220) [v3] Add multi-site suffix to auth token keys (#1208) Footer: fix hydration error with the locale dropdown (#1210) remove unused peerDependency @chakra-ui/system (#1212) @W-12582733: Expose env vars endpoint for E2E smoke tests (#1207) Upgrade to React 18 (#1166) Remove v3 branch name related actions (#1206) add test to reach test coverage threshold remove commerce-api folder Feature: Extract einstein RefArch-specific values to constant (#1200) Bump version number to 2.7.1 and update changelogs (#1197) store usid in cookies (#1193) make sure static files are copied on dev environment (#1196) [WIP] PWA Kit 2.7.1 release (#1181) [V2] Internal lib build typescript dev dependency (#1194) [V2] Re-generate lock files and fix hook lib tests (#1186) [v3] Add Convenience Components (#1183) Update commerce-sdk-react README (#1176) Add additional properties to ShopperLogin test types (#1185) Fix missing commerce-sdk-react logout call (#1180) ... # Conflicts: # package-lock.json # packages/commerce-sdk-react/CHANGELOG.md # packages/commerce-sdk-react/package-lock.json # packages/internal-lib-build/package-lock.json # packages/pwa-kit-create-app/package-lock.json # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-react-sdk/package-lock.json # packages/pwa-kit-runtime/package-lock.json # packages/template-mrt-reference-app/package-lock.json # packages/template-retail-react-app/package-lock.json # packages/template-typescript-minimal/package-lock.json # packages/test-commerce-sdk-react/package-lock.json

* develop: (34 commits) [Phased Launch] Call Session bridge after login (#1220) [v3] Add multi-site suffix to auth token keys (#1208) Footer: fix hydration error with the locale dropdown (#1210) remove unused peerDependency @chakra-ui/system (#1212) @W-12582733: Expose env vars endpoint for E2E smoke tests (#1207) Upgrade to React 18 (#1166) Remove v3 branch name related actions (#1206) add test to reach test coverage threshold remove commerce-api folder Feature: Extract einstein RefArch-specific values to constant (#1200) Bump version number to 2.7.1 and update changelogs (#1197) store usid in cookies (#1193) make sure static files are copied on dev environment (#1196) [WIP] PWA Kit 2.7.1 release (#1181) [V2] Internal lib build typescript dev dependency (#1194) [V2] Re-generate lock files and fix hook lib tests (#1186) Add additional properties to ShopperLogin test types (#1185) Revert 2.7.0 branch to prep for 2.7.1 changes (#1182) #1174 Replace invalid value for wrap property (#1179) Add a redirect to login page after user signs out from checkout page (#1172) ... # Conflicts: # package-lock.json # packages/commerce-sdk-react/CHANGELOG.md # packages/commerce-sdk-react/package-lock.json # packages/internal-lib-build/package-lock.json # packages/pwa-kit-create-app/package-lock.json # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-dev/package.json # packages/pwa-kit-react-sdk/package-lock.json # packages/pwa-kit-runtime/package-lock.json # packages/template-mrt-reference-app/package-lock.json # packages/template-retail-react-app/app/components/confirmation-modal/index.test.js # packages/template-retail-react-app/app/components/footer/index.jsx # packages/template-retail-react-app/app/components/header/index.jsx # packages/template-retail-react-app/app/components/list-menu/index.test.js # packages/template-retail-react-app/app/components/product-scroller/index.test.js # packages/template-retail-react-app/app/components/product-view-modal/index.test.js # packages/template-retail-react-app/app/components/search/index.test.js # packages/template-retail-react-app/app/hoc/with-registration/index.test.js # packages/template-retail-react-app/app/hooks/use-add-to-cart-modal.js # packages/template-retail-react-app/app/hooks/use-auth-modal.test.js # packages/template-retail-react-app/app/hooks/use-currency.test.js # packages/template-retail-react-app/app/hooks/use-multi-site.test.js # packages/template-retail-react-app/app/hooks/use-navigation.test.js # packages/template-retail-react-app/app/pages/account/addresses.test.js # packages/template-retail-react-app/app/pages/account/index.jsx # packages/template-retail-react-app/app/pages/account/wishlist/partials/wishlist-primary-action.test.js # packages/template-retail-react-app/app/pages/cart/index.test.js # packages/template-retail-react-app/app/pages/cart/partials/cart-secondary-button-group.test.js # packages/template-retail-react-app/app/pages/checkout/index.test.js # packages/template-retail-react-app/app/pages/checkout/partials/contact-info.jsx # packages/template-retail-react-app/app/pages/checkout/partials/contact-info.test.js # packages/template-retail-react-app/app/pages/home/index.test.js # packages/template-retail-react-app/app/pages/product-list/partials/empty-results.jsx # packages/template-retail-react-app/app/pages/product-list/partials/page-header.jsx # packages/template-retail-react-app/app/pages/registration/index.test.jsx # packages/template-retail-react-app/app/utils/site-utils.js # packages/template-retail-react-app/package-lock.json # packages/template-typescript-minimal/package-lock.json # packages/test-commerce-sdk-react/package-lock.json

@bendvc

…react-app * feature/template-extensibility: (38 commits) support windows file paths Feature/template extensibility (#1162) lockfiles from reaact18 / chakra2 remove demo extensible app in light of soon-to-be-merged PR from @bendvc [Phased Launch] Call Session bridge after login (#1220) [v3] Add multi-site suffix to auth token keys (#1208) Footer: fix hydration error with the locale dropdown (#1210) remove unused peerDependency @chakra-ui/system (#1212) @W-12582733: Expose env vars endpoint for E2E smoke tests (#1207) Upgrade to React 18 (#1166) Remove v3 branch name related actions (#1206) add test to reach test coverage threshold remove commerce-api folder Feature: Extract einstein RefArch-specific values to constant (#1200) Bump version number to 2.7.1 and update changelogs (#1197) store usid in cookies (#1193) make sure static files are copied on dev environment (#1196) [WIP] PWA Kit 2.7.1 release (#1181) [V2] Internal lib build typescript dev dependency (#1194) [V2] Re-generate lock files and fix hook lib tests (#1186) ... # Conflicts: # packages/my-extended-retail-app/config/default.js # packages/my-extended-retail-app/config/sites.js # packages/my-extended-retail-app/package-lock.json # packages/my-extended-retail-app/package.json # packages/my-extended-retail-app/pwa-kit-overrides/app/assets/svg/brand-logo.svg # packages/my-extended-retail-app/pwa-kit-overrides/app/components/_app-config/index.jsx # packages/my-extended-retail-app/pwa-kit-overrides/app/components/_app/index.jsx # packages/my-extended-retail-app/pwa-kit-overrides/app/pages/home/index.jsx # packages/my-extended-retail-app/pwa-kit-overrides/app/routes.jsx # packages/my-extended-retail-app/pwa-kit-overrides/app/ssr.js # packages/my-extended-retail-app/pwa-kit-overrides/app/static/ico/favicon.ico # packages/my-extended-retail-app/pwa-kit-overrides/app/static/img/global/app-icon-192.png # packages/my-extended-retail-app/pwa-kit-overrides/app/static/img/global/app-icon-512.png # packages/my-extended-retail-app/pwa-kit-overrides/app/static/img/global/apple-touch-icon.png # packages/pwa-kit-dev/bin/pwa-kit-dev.js # packages/pwa-kit-dev/package-lock.json # packages/pwa-kit-dev/package.json # packages/pwa-kit-dev/src/configs/webpack/config.js # packages/template-retail-react-app/app/components/confirmation-modal/index.test.js # packages/template-retail-react-app/app/components/footer/index.jsx # packages/template-retail-react-app/app/components/header/index.jsx # packages/template-retail-react-app/app/components/list-menu/index.test.js # packages/template-retail-react-app/app/components/product-scroller/index.test.js # packages/template-retail-react-app/app/components/product-view-modal/index.test.js # packages/template-retail-react-app/app/components/search/index.test.js # packages/template-retail-react-app/app/hoc/with-registration/index.test.js # packages/template-retail-react-app/app/hooks/use-add-to-cart-modal.js # packages/template-retail-react-app/app/hooks/use-auth-modal.test.js # packages/template-retail-react-app/app/hooks/use-currency.test.js # packages/template-retail-react-app/app/hooks/use-multi-site.test.js # packages/template-retail-react-app/app/hooks/use-navigation.test.js # packages/template-retail-react-app/app/pages/account/addresses.test.js # packages/template-retail-react-app/app/pages/account/index.jsx # packages/template-retail-react-app/app/pages/account/wishlist/index.test.js # packages/template-retail-react-app/app/pages/account/wishlist/partials/wishlist-primary-action.test.js # packages/template-retail-react-app/app/pages/cart/index.test.js # packages/template-retail-react-app/app/pages/cart/partials/cart-secondary-button-group.test.js # packages/template-retail-react-app/app/pages/checkout/index.test.js # packages/template-retail-react-app/app/pages/checkout/partials/contact-info.jsx # packages/template-retail-react-app/app/pages/checkout/partials/contact-info.test.js # packages/template-retail-react-app/app/pages/home/index.test.js # packages/template-retail-react-app/app/pages/product-list/partials/empty-results.jsx # packages/template-retail-react-app/app/pages/product-list/partials/page-header.jsx # packages/template-retail-react-app/app/pages/registration/index.test.jsx # packages/template-retail-react-app/app/utils/site-utils.js # packages/template-retail-react-app/package-lock.json # packages/template-retail-react-app/package.json

josebarrios-sfdc added 2 commits May 8, 2023 05:43

Adding smoke test route and response

2661ea6

Env vars endpoint

20fb5d8

josebarrios-sfdc self-assigned this May 15, 2023

josebarrios-sfdc and others added 3 commits May 15, 2023 10:58

Removing testing vars

3653a44

Reverting package.json testing changes

1e49097

Merge branch 'develop' into custom-env-var-smoke-tests

57b7829

josebarrios-sfdc marked this pull request as ready for review May 15, 2023 18:10

josebarrios-sfdc requested a review from a team as a code owner May 15, 2023 18:10

bfeister reviewed May 15, 2023

View reviewed changes

packages/template-mrt-reference-app/app/ssr.js Outdated Show resolved Hide resolved

bfeister reviewed May 15, 2023

View reviewed changes

.gitignore Show resolved Hide resolved

bfeister previously approved these changes May 15, 2023

View reviewed changes

Linted

2251e44

josebarrios-sfdc dismissed bfeister’s stale review via 2251e44 May 15, 2023 20:02

Merge branch 'develop' into custom-env-var-smoke-tests

6ab180b

bfeister previously approved these changes May 15, 2023

View reviewed changes

johnboxall reviewed May 15, 2023

View reviewed changes

packages/template-mrt-reference-app/app/ssr.js Outdated Show resolved Hide resolved

johnboxall reviewed May 15, 2023

View reviewed changes

packages/template-mrt-reference-app/app/ssr.js Outdated Show resolved Hide resolved

johnboxall previously approved these changes May 15, 2023

View reviewed changes

josebarrios-sfdc added 2 commits May 15, 2023 14:41

Removing env-var endpoint since we already expose them, added wildcard

d16593e

Merge branch 'custom-env-var-smoke-tests' of github.com:SalesforceCom…

4b0fc4d

…merceCloud/pwa-kit into custom-env-var-smoke-tests

josebarrios-sfdc dismissed stale reviews from johnboxall and bfeister via 4b0fc4d May 15, 2023 21:43

bfeister previously approved these changes May 16, 2023

View reviewed changes

Merge branch 'develop' into custom-env-var-smoke-tests

ef9bf2c

johnboxall reviewed May 16, 2023

View reviewed changes

packages/template-mrt-reference-app/app/ssr.test.js Outdated Show resolved Hide resolved

josebarrios-sfdc added 2 commits May 15, 2023 22:29

Removed vestigious env var test

4b09b31

Merge branch 'custom-env-var-smoke-tests' of github.com:SalesforceCom…

7cd0b85

…merceCloud/pwa-kit into custom-env-var-smoke-tests

josebarrios-sfdc dismissed bfeister’s stale review via 7cd0b85 May 16, 2023 05:32

johnboxall approved these changes May 16, 2023

View reviewed changes

kenjush approved these changes May 16, 2023

View reviewed changes

josebarrios-sfdc merged commit 78ad417 into develop May 16, 2023
17 checks passed

josebarrios-sfdc deleted the custom-env-var-smoke-tests branch May 16, 2023 18:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@W-12582733: Expose env vars endpoint for E2E smoke tests #1207

@W-12582733: Expose env vars endpoint for E2E smoke tests #1207

josebarrios-sfdc commented May 15, 2023 •

edited

Loading

bfeister left a comment

johnboxall left a comment

@W-12582733: Expose env vars endpoint for E2E smoke tests #1207

@W-12582733: Expose env vars endpoint for E2E smoke tests #1207

Conversation

josebarrios-sfdc commented May 15, 2023 • edited Loading

How to Test-Drive This PR

bfeister left a comment

Choose a reason for hiding this comment

johnboxall left a comment

Choose a reason for hiding this comment

josebarrios-sfdc commented May 15, 2023 •

edited

Loading